Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1966093005: [MD settings] i18n-content to $i18n switch in People settings (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 6 months ago
Reviewers:
tommycli, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] i18n-content to $i18n switch in People settings This CL has mechanical change to switch i18n-content and i18n-values entries to $i18n within the People settings. BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/985964f63cb9b6fda0517e21e265c75765b7d27c Cr-Commit-Position: refs/heads/master@{#393104}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -40 lines) Patch
M chrome/browser/resources/settings/people_page/camera.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 4 chunks +11 lines, -11 lines 1 comment Download
M chrome/browser/resources/settings/people_page/sync_page.html View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/people_page/users_page.html View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-11 22:04:49 UTC) #3
tommycli
LGTM thanks for doing this
4 years, 7 months ago (2016-05-11 22:06:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966093005/1
4 years, 7 months ago (2016-05-11 23:24:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 23:30:42 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/985964f63cb9b6fda0517e21e265c75765b7d27c Cr-Commit-Position: refs/heads/master@{#393104}
4 years, 7 months ago (2016-05-11 23:32:53 UTC) #9
Dan Beam
4 years, 6 months ago (2016-06-20 23:20:18 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1966093005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/1966093005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.html:215:
<div>$i18nRaw{syncDisconnectExplanation}"</div>
whoops

Powered by Google App Engine
This is Rietveld 408576698