Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4433)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.html

Issue 1966093005: [MD settings] i18n-content to $i18n switch in People settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/change_picture.html
diff --git a/chrome/browser/resources/settings/people_page/change_picture.html b/chrome/browser/resources/settings/people_page/change_picture.html
index 7f2fcabe014e8676be270c1fa9cd897cb128f213..60bb4cd24dca995d26ffa3dfcb40463515d21506 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.html
+++ b/chrome/browser/resources/settings/people_page/change_picture.html
@@ -24,15 +24,15 @@
selected-item="{{selectedItem_}}">
<iron-icon id="cameraImage"
data-type$="[[selectionTypesEnum_.CAMERA]]"
- icon="settings:camera-alt" i18n-values="alt:takePhoto"
+ icon="settings:camera-alt" alt="$i18n{takePhoto}"
hidden="[[!cameraPresent_]]">
</iron-icon>
<iron-icon data-type$="[[selectionTypesEnum_.FILE]]"
- icon="settings:folder" i18n-values="alt:chooseFile">
+ icon="settings:folder" alt="$i18n{chooseFile}">
</iron-icon>
<img id="profileImage"
data-type$="[[selectionTypesEnum_.PROFILE]]"
- src="[[profileImageUrl_]]" i18n-values="alt:profilePhotoLoading">
+ src="[[profileImageUrl_]]" alt="$i18n{profilePhotoLoading}">
<img id="oldImage" data-type$="[[selectionTypesEnum_.OLD]]"
src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]">
<template is="dom-repeat" items="[[defaultImages_]]">
@@ -53,11 +53,12 @@
</template>
</div>
<div id="previewPane">
- <img i18n-values="alt:previewAltText" src="[[selectedItem_.src]]"
+ <img alt="$i18n{previewAltText}" src="[[selectedItem_.src]]"
hidden="[[isPreviewImageHidden_(selectedItem_)]]">
- <div id="discardControlBar" hidden="[[isDiscardHidden_(selectedItem_)]]">
+ <div id="discardControlBar"
+ hidden="[[isDiscardHidden_(selectedItem_)]]">
<paper-icon-button id="discardOldImage" tabindex="0"
- icon="settings:delete" i18n-values="title:discardPhoto"
+ icon="settings:delete" title="$i18n{discardPhoto}"
on-tap="onTapDiscardOldImage_">
</paper-icon-button>
</div>

Powered by Google App Engine
This is Rietveld 408576698