Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 1966093005: [MD settings] i18n-content to $i18n switch in People settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 234a5c657b6e0fd8d3b11fdb4ffaadbabd062b03..290134f308e3b21a9e79cc974340940be8b01160 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -128,7 +128,7 @@
<if expr="chromeos">
<div class="settings-box">
<settings-checkbox pref="{{prefs.settings.enable_screen_lock}}"
- i18n-values="label:enableScreenlock">
+ label="$i18n{enableScreenlock}">
</settings-checkbox>
</div>
@@ -151,7 +151,7 @@
if="[[easyUnlockProximityDetectionAllowed_]]">
<settings-checkbox
pref="{{prefs.easy_unlock.proximity_required}}"
- i18n-values="label:easyUnlockRequireProximityLabel">
+ label="$i18n{easyUnlockRequireProximityLabel}">
</settings-checkbox>
</template>
</template>
@@ -176,8 +176,8 @@
</if>
<div class="settings-box">
- <paper-button class="primary-button" i18n-content="manageOtherPeople"
- on-tap="onManageOtherPeople_">
+ <paper-button class="primary-button" on-tap="onManageOtherPeople_">
+ $i18n{manageOtherPeople}
</paper-button>
</div>
</neon-animatable>
@@ -211,18 +211,18 @@
</settings-animated-pages>
<paper-dialog modal id="disconnectDialog">
- <h2 i18n-content="syncDisconnectTitle"></h2>
- <div i18n-values=".innerHTML:syncDisconnectExplanation"></div>
+ <h2>$i18n{syncDisconnectTitle}</h2>
+ <div>$i18nRaw{syncDisconnectExplanation}"</div>
Dan Beam 2016/06/20 23:20:18 whoops
<if expr="(not chromeos and is_posix) or is_win or is_macosx">
- <paper-checkbox id="deleteProfile"
- i18n-content="syncDisconnectDeleteProfile">
+ <paper-checkbox id="deleteProfile">
+ $i18n{syncDisconnectDeleteProfile}
</paper-checkbox>
</if>
<div class="button-strip">
- <paper-button dialog-dismiss i18n-content="cancel">
- </paper-button>
+ <paper-button dialog-dismiss>$i18n{cancel}</paper-button>
<paper-button dialog-confirm class="action-button"
- on-tap="onDisconnectConfirm_" i18n-content="syncDisconnectConfirm">
+ on-tap="onDisconnectConfirm_">
+ $i18n{syncDisconnectConfirm}
</paper-button>
</div>
</paper-dialog>

Powered by Google App Engine
This is Rietveld 408576698