Remove the implicit add of Vary: Cookie on redirected requests

Remove the implicit add of Vary: Cookie on redirected requests

BUG=582080, 469675
Committed: https://crrev.com/dd6d9b151168ac4e07f197aa8f463b5735ac9d11
Cr-Commit-Position: refs/heads/master@{#392956}

[gabadie, 2016-05-10 16:44:20]

The CQ bit was checked by gabadie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-10 16:44:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965833002/1

[commit-bot: I haz the power, 2016-05-10 17:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 17:07:19]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[gabadie, 2016-05-11 10:45:02]

gabadie@chromium.org changed reviewers:
+ gavinp@chromium.org, mmenke@chromium.org

[gabadie, 2016-05-11 10:45:03]

Hello there,

This CL removes the implicit Vary: Cookie on redirected requests. PTAL. =)

[mmenke, 2016-05-11 12:19:28]

On 2016/05/11 10:45:03, gabadie wrote:
> Hello there,
> 
> This CL removes the implicit Vary: Cookie on redirected requests. PTAL. =)

I'll defer to Gavin on this one.

[pasko, 2016-05-11 13:20:22]

fly-by non-owner lgtm

[gavinp, 2016-05-11 14:29:15]

lgtm if we remove the unused test data.

I created issue 611049 to track the larger issue of going over all status codes
for cacheability; I'm sad to see Firefox is more aggressive than us.

https://codereview.chromium.org/1965833002/diff/20001/net/http/http_vary_data...
File net/http/http_vary_data_unittest.cc (right):

https://codereview.chromium.org/1965833002/diff/20001/net/http/http_vary_data...
net/http/http_vary_data_unittest.cc:127: TestTransaction b;
This isn't used now, right?

[gabadie, 2016-05-11 15:50:57]

Thanks Gavin! Uploaded a new revision removing the unnecessary stuff from the
unittest. My bad. Landing.

https://codereview.chromium.org/1965833002/diff/20001/net/http/http_vary_data...
File net/http/http_vary_data_unittest.cc (right):

https://codereview.chromium.org/1965833002/diff/20001/net/http/http_vary_data...
net/http/http_vary_data_unittest.cc:127: TestTransaction b;
On 2016/05/11 14:29:14, gavinp wrote:
> This isn't used now, right?

Oups. Done.

[gabadie, 2016-05-11 15:51:04]

The CQ bit was checked by gabadie@chromium.org

[gabadie, 2016-05-11 15:51:04]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org,
gavinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1965833002/#ps40001
(title: "Addresses Favin's comment")

[commit-bot: I haz the power, 2016-05-11 15:51:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965833002/40001

[commit-bot: I haz the power, 2016-05-11 16:52:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-11 16:55:44]

Description was changed from

==========
Remove the implicit add of Vary: Cookie on redirected requests

BUG=582080,469675
==========

to

==========
Remove the implicit add of Vary: Cookie on redirected requests

BUG=582080,469675

Committed: https://crrev.com/dd6d9b151168ac4e07f197aa8f463b5735ac9d11
Cr-Commit-Position: refs/heads/master@{#392956}
==========

[commit-bot: I haz the power, 2016-05-11 16:55:45]

Patchset 3 (id:??) landed as
https://crrev.com/dd6d9b151168ac4e07f197aa8f463b5735ac9d11
Cr-Commit-Position: refs/heads/master@{#392956}