Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: net/http/http_vary_data.cc

Issue 1965833002: Remove the implicit add of Vary: Cookie on redirected requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Gavin's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_vary_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_vary_data.cc
diff --git a/net/http/http_vary_data.cc b/net/http/http_vary_data.cc
index 6b3a02a9214ef8140a1699ef2652fd8f3f9ee11c..a8faf56ffdfb03d8578928597e2471828c0691cb 100644
--- a/net/http/http_vary_data.cc
+++ b/net/http/http_vary_data.cc
@@ -41,22 +41,6 @@ bool HttpVaryData::Init(const HttpRequestInfo& request_info,
processed_header = true;
}
- // Add an implicit 'Vary: cookie' header to any redirect to avoid redirect
- // loops which may result from redirects that are incorrectly marked as
- // cachable by the server. Unfortunately, other browsers do not cache
- // redirects that result from requests containing a cookie header. We are
- // treading on untested waters here, so we want to be extra careful to make
- // sure we do not end up with a redirect loop served from cache.
- //
- // If there is an explicit 'Vary: cookie' header, then we will just end up
- // digesting the cookie header twice. Not a problem.
- //
- std::string location;
- if (response_headers.IsRedirect(&location)) {
- AddField(request_info, "cookie", &ctx);
- processed_header = true;
- }
-
if (!processed_header)
return false;
« no previous file with comments | « no previous file | net/http/http_vary_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698