Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: net/http/http_vary_data_unittest.cc

Issue 1965833002: Remove the implicit add of Vary: Cookie on redirected requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Gavin's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_vary_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_vary_data_unittest.cc
diff --git a/net/http/http_vary_data_unittest.cc b/net/http/http_vary_data_unittest.cc
index c9bff658451dc52feb08224441f47c21914377de..f1d881a9203c7d44fa1f8b993870ab3d012c42d5 100644
--- a/net/http/http_vary_data_unittest.cc
+++ b/net/http/http_vary_data_unittest.cc
@@ -120,32 +120,12 @@ TEST(HttpVaryDataTest, DoesntVary2) {
EXPECT_TRUE(v.MatchesRequest(b.request, *b.response.get()));
}
-TEST(HttpVaryDataTest, ImplicitCookieForRedirect) {
+TEST(HttpVaryDataTest, DoesntVaryByCookieForRedirect) {
TestTransaction a;
a.Init("Cookie: 1", "HTTP/1.1 301 Moved\nLocation: x\n\n");
- TestTransaction b;
- b.Init("Cookie: 2", "HTTP/1.1 301 Moved\nLocation: x\n\n");
-
- HttpVaryData v;
- EXPECT_TRUE(v.Init(a.request, *a.response.get()));
-
- EXPECT_FALSE(v.MatchesRequest(b.request, *b.response.get()));
-}
-
-TEST(HttpVaryDataTest, ImplicitCookieForRedirect2) {
- // This should be no different than the test above
-
- TestTransaction a;
- a.Init("Cookie: 1", "HTTP/1.1 301 Moved\nLocation: x\nVary: coOkie\n\n");
-
- TestTransaction b;
- b.Init("Cookie: 2", "HTTP/1.1 301 Moved\nLocation: x\nVary: cooKie\n\n");
-
HttpVaryData v;
- EXPECT_TRUE(v.Init(a.request, *a.response.get()));
-
- EXPECT_FALSE(v.MatchesRequest(b.request, *b.response.get()));
+ EXPECT_FALSE(v.Init(a.request, *a.response.get()));
}
} // namespace net
« no previous file with comments | « net/http/http_vary_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698