Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965583002: Move //webapk to //chrome/android/webapk (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Yaron
CC:
Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move //webapk to //chrome/android/webapk BUG=609122

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-12 lines, -2502 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M apk_minter/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 5 chunks +5 lines, -7 lines 0 comments Download
A + chrome/android/webapk/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NotificationBuilderDelegate.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NotificationClient.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkStateParams.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkSwitches.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersion.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersionManager.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/common/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkUtils.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/runtime_library/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/webapk/libs/runtime_library/junit/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/runtime_library/src/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.aidl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/common.aidl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/libs/runtime_library_version.gni View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/canary_lib/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/canary_lib/src/org/chromium/webapk/shell_apk/test/canary/Canary.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/dex_optimizer/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/dex_optimizer/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/DexOptimizerServiceImpl.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/IDexOptimizerService.aidl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/common.aidl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/proguard.flags View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/res/drawable-mdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/webapk/shell_apk/res/layout/main.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/DexLoader.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/Reflect.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkApplication.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
D webapk/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D webapk/libs/client/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java View 1 chunk +0 lines, -189 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java View 1 chunk +0 lines, -55 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/NotificationBuilderDelegate.java View 1 chunk +0 lines, -43 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/NotificationClient.java View 1 chunk +0 lines, -135 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkStateParams.java View 1 chunk +0 lines, -46 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkSwitches.java View 1 chunk +0 lines, -14 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 chunk +0 lines, -122 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersion.template View 1 chunk +0 lines, -11 lines 0 comments Download
D webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersionManager.java View 1 chunk +0 lines, -70 lines 0 comments Download
D webapk/libs/common/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java View 1 chunk +0 lines, -16 lines 0 comments Download
D webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkUtils.java View 1 chunk +0 lines, -71 lines 0 comments Download
D webapk/libs/runtime_library/BUILD.gn View 1 chunk +0 lines, -53 lines 0 comments Download
D webapk/libs/runtime_library/junit/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java View 1 chunk +0 lines, -100 lines 0 comments Download
D webapk/libs/runtime_library/src/README View 1 chunk +0 lines, -18 lines 0 comments Download
D webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.aidl View 1 chunk +0 lines, -27 lines 0 comments Download
D webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java View 1 chunk +0 lines, -98 lines 0 comments Download
D webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/common.aidl View 1 chunk +0 lines, -7 lines 0 comments Download
D webapk/libs/runtime_library_version.gni View 1 chunk +0 lines, -8 lines 0 comments Download
D webapk/shell_apk/AndroidManifest.xml View 1 chunk +0 lines, -77 lines 0 comments Download
D webapk/shell_apk/BUILD.gn View 1 chunk +0 lines, -92 lines 0 comments Download
D webapk/shell_apk/javatests/canary_lib/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D webapk/shell_apk/javatests/canary_lib/src/org/chromium/webapk/shell_apk/test/canary/Canary.java View 1 chunk +0 lines, -8 lines 0 comments Download
D webapk/shell_apk/javatests/dex_optimizer/AndroidManifest.xml View 1 chunk +0 lines, -21 lines 0 comments Download
D webapk/shell_apk/javatests/dex_optimizer/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/DexOptimizerServiceImpl.java View 1 chunk +0 lines, -64 lines 0 comments Download
D webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/IDexOptimizerService.aidl View 1 chunk +0 lines, -13 lines 0 comments Download
D webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/common.aidl View 1 chunk +0 lines, -5 lines 0 comments Download
D webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java View 1 chunk +0 lines, -319 lines 0 comments Download
D webapk/shell_apk/proguard.flags View 1 chunk +0 lines, -63 lines 0 comments Download
D webapk/shell_apk/res/drawable-mdpi/app_icon.png View Binary file 0 comments Download
D webapk/shell_apk/res/layout/main.xml View 1 chunk +0 lines, -11 lines 0 comments Download
D webapk/shell_apk/src/org/chromium/webapk/shell_apk/DexLoader.java View 1 chunk +0 lines, -147 lines 0 comments Download
D webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java View 1 chunk +0 lines, -122 lines 0 comments Download
D webapk/shell_apk/src/org/chromium/webapk/shell_apk/Reflect.java View 1 chunk +0 lines, -66 lines 0 comments Download
D webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkApplication.java View 1 chunk +0 lines, -155 lines 0 comments Download
D webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java View 1 chunk +0 lines, -168 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
pkotwicz
Yaron, can you please take a look?
4 years, 7 months ago (2016-05-09 22:12:17 UTC) #2
Yaron
4 years, 7 months ago (2016-05-09 22:22:31 UTC) #4 
lgtm - but we have to work do! I think the content refactoring we discussed my
have legs

https://codereview.chromium.org/1965583002/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/1965583002/diff/1/base/BUILD.gn#newcode2170
base/BUILD.gn:2170: "//chrome/android/webapk/libs/common",
:S - that aint gonna werk

Powered by Google App Engine
This is Rietveld 408576698