chrome/android/webapk/libs/runtime_library/src/README - Issue 1965583002: Move //webapk to //chrome/android/webapk

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/webapk/libs/runtime_library/src/README

Issue 1965583002: Move //webapk to //chrome/android/webapk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/webapk/libs/runtime_library/junit/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java ('k') | chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.aidl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 The runtime library contains the implementation of the Web APK service. It	1 The runtime library contains the implementation of the Web APK service. It

2 implements functionality which Chrome delegates to the Web APK such as	2 implements functionality which Chrome delegates to the Web APK such as

3 displaying notifications. The library is loaded by a ShellAPK which	3 displaying notifications. The library is loaded by a ShellAPK which

4 contains the Web APK's manifest and code to load the runtime library.	4 contains the Web APK's manifest and code to load the runtime library.

5	5

6 The latest version of the runtime library is	6 The latest version of the runtime library is

7 extracted from Chrome's APK by the ShellAPK when the Web APK service is created.	7 extracted from Chrome's APK by the ShellAPK when the Web APK service is created.

8 Since the ShellAPK is updated asynchronously, the runtime library may run within	8 Since the ShellAPK is updated asynchronously, the runtime library may run within

9 an old ShellAPK. For instance, the ShellAPK's Android manifest may be missing	9 an old ShellAPK. For instance, the ShellAPK's Android manifest may be missing

10 some of the permissions that the runtime library is expecting.	10 some of the permissions that the runtime library is expecting.

11	11

12 As the runtime library code does not execute in any of Chrome's processes, and	12 As the runtime library code does not execute in any of Chrome's processes, and

13 runs in a separate application/process, it must not depend on anything in Chrome	13 runs in a separate application/process, it must not depend on anything in Chrome

14 including //base.	14 including //base.

15	15

16 The number in runtime_library_version.gni must be incremented whenever the	16 The number in runtime_library_version.gni must be incremented whenever the

17 runtime library is updated. The WebAPK re-extracts the runtime library from the	17 runtime library is updated. The WebAPK re-extracts the runtime library from the

18 Chrome APK when the version number is incremented.	18 Chrome APK when the version number is incremented.

OLD	NEW