Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965563002: Neuter the wrong-way ServiceProvider (a.k.a. exposed_services). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work795_js_wrong_way
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Neuter the wrong-way ServiceProvider (a.k.a. exposed_services). You can still give it to ConnectToApplication(), but mojo_shell will drop it on the floor. R=vardhan@google.com BUG=#762 Committed: https://chromium.googlesource.com/external/mojo/+/d588c9404406f04632eabb4c15e650aa26d050aa

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -92 lines) Patch
M mojo/public/interfaces/application/application.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/interfaces/application/application_connector.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/interfaces/application/shell.mojom View 1 chunk +7 lines, -1 line 0 comments Download
M shell/application_manager/application_manager.h View 3 chunks +5 lines, -13 lines 0 comments Download
M shell/application_manager/application_manager.cc View 12 chunks +30 lines, -51 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/shell_impl.h View 1 chunk +3 lines, -5 lines 0 comments Download
M shell/application_manager/shell_impl.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M shell/context.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M shell/native_runner_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M shell/shell_test_base.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1964673002/.
4 years, 7 months ago (2016-05-09 21:44:14 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-09 21:50:48 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-09 23:49:50 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d588c9404406f04632eabb4c15e650aa26d050aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698