mojo/public/interfaces/application/application.mojom - Issue 1965563002: Neuter the wrong-way ServiceProvider (a.k.a. exposed_services).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/application/application.mojom

Issue 1965563002: Neuter the wrong-way ServiceProvider (a.k.a. exposed_services). (Closed) Base URL: https://github.com/domokit/mojo.git@work795_js_wrong_way

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/interfaces/application/application.mojom

diff --git a/mojo/public/interfaces/application/application.mojom b/mojo/public/interfaces/application/application.mojom

index 7f1ebe51474da518dbe5a8749f3283dcfd1e563d..0ed5154e148e057b3e8478f034d50368ccf61081 100644

--- a/mojo/public/interfaces/application/application.mojom

+++ b/mojo/public/interfaces/application/application.mojom

@@ -50,6 +50,10 @@ interface Application {

// resolved_url is the URL that was requested to create this connection, after

// all mappings, resolutions, and redirects. This will include any querystring

// that was part of the request.

+ //

+ // WARNING: |exposed_services| is deprecated and non-functional, and will be

+ // removed. Note that this also means that |services| will become required.

+ // https://github.com/domokit/mojo/issues/762

AcceptConnection(string requestor_url,

ServiceProvider&? services,

ServiceProvider? exposed_services,

« no previous file with comments | « no previous file | mojo/public/interfaces/application/application_connector.mojom » ('j') | no next file with comments »