Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: shell/application_manager/application_manager.h

Issue 1965563002: Neuter the wrong-way ServiceProvider (a.k.a. exposed_services). (Closed) Base URL: https://github.com/domokit/mojo.git@work795_js_wrong_way
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/interfaces/application/shell.mojom ('k') | shell/application_manager/application_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/application_manager.h
diff --git a/shell/application_manager/application_manager.h b/shell/application_manager/application_manager.h
index 72cc947547e1faa3d4e90b6dfd587f5b2a9b93e4..edfb46ec90ac0d118d10e94e5c7ced7aff64a22e 100644
--- a/shell/application_manager/application_manager.h
+++ b/shell/application_manager/application_manager.h
@@ -81,7 +81,6 @@ class ApplicationManager {
const GURL& application_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end);
template <typename Interface>
@@ -156,21 +155,18 @@ class ApplicationManager {
const GURL& application_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& pre_redirect_parameters);
bool ConnectToRunningApplication(
const GURL& resolved_url,
const GURL& requestor_url,
- mojo::InterfaceRequest<mojo::ServiceProvider>* services,
- mojo::InterfaceHandle<mojo::ServiceProvider>* exposed_services);
+ mojo::InterfaceRequest<mojo::ServiceProvider>* services);
bool ConnectToApplicationWithLoader(
const GURL& resolved_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider>* services,
- mojo::InterfaceHandle<mojo::ServiceProvider>* exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& parameters,
ApplicationLoader* loader);
@@ -188,23 +184,19 @@ class ApplicationManager {
const GURL& resolved_url,
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& parameters);
ShellImpl* GetShellImpl(const GURL& url);
- void ConnectToClient(
- ShellImpl* shell_impl,
- const GURL& resolved_url,
- const GURL& requestor_url,
- mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services);
+ void ConnectToClient(ShellImpl* shell_impl,
+ const GURL& resolved_url,
+ const GURL& requestor_url,
+ mojo::InterfaceRequest<mojo::ServiceProvider> services);
void HandleFetchCallback(
const GURL& requestor_url,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::InterfaceHandle<mojo::ServiceProvider> exposed_services,
const base::Closure& on_application_end,
const std::vector<std::string>& parameters,
scoped_ptr<Fetcher> fetcher);
« no previous file with comments | « mojo/public/interfaces/application/shell.mojom ('k') | shell/application_manager/application_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698