MD Settings: Page and animation fixes

MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

Stops sections from disappearing as soon as the expand
animation begins.

R=dpapad@chromium.org
BUG=610429, 608598
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c
Cr-Commit-Position: refs/heads/master@{#392480}

[michaelpg, 2016-05-09 21:22:43]

Description was changed from

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

R=dpapad@chromium.org
BUG=610429
==========

to

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

R=dpapad@chromium.org
BUG=610429
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-09 21:24:20]

Description was changed from

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

R=dpapad@chromium.org
BUG=610429
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

Stops sections from disappearing as soon as the expand
animation begins.

R=dpapad@chromium.org
BUG=610429,608598
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-09 21:24:47]

dpapad, PTAL. +dschuyler@ for fyi

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:20:
min-height: calc(100% + 48px);
this is slightly unfortunate, but it works.

we should combine these styles with settings_page.css anyway,
so at least these magic numbers will be in the same place.

[dpapad, 2016-05-09 21:34:58]

lgtm

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:20:
min-height: calc(100% + 48px);
On 2016/05/09 at 21:24:47, michaelpg wrote:
> this is slightly unfortunate, but it works.
> 
> we should combine these styles with settings_page.css anyway,
> so at least these magic numbers will be in the same place.

This indeed seems like magic, so I trust you that it works, and +1 on cleaning
this up to make it less cryptic.

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:114:
if (newRouteIsSubpage && newRoute.section == this.section)
Nit (optional): Ternary operator could be used here.

this.$.animatedPages.selected =
    (newRouteIsSubpage && newRoute.section == this.section) ?
        newRoute.subpage.slice(-1)[0] : 'main';

[michaelpg, 2016-05-09 23:12:39]

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1965553002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:114:
if (newRouteIsSubpage && newRoute.section == this.section)
On 2016/05/09 21:34:58, dpapad wrote:
> Nit (optional): Ternary operator could be used here.
> 
> this.$.animatedPages.selected =
>     (newRouteIsSubpage && newRoute.section == this.section) ?
>         newRoute.subpage.slice(-1)[0] : 'main';

Think I'll keep it as is. I tried it a couple ways and the ternary just never
looked right to me.

[michaelpg, 2016-05-09 23:12:42]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-05-09 23:13:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965553002/1

[commit-bot: I haz the power, 2016-05-09 23:51:37]

Description was changed from

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

Stops sections from disappearing as soon as the expand
animation begins.

R=dpapad@chromium.org
BUG=610429,608598
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

Stops sections from disappearing as soon as the expand
animation begins.

R=dpapad@chromium.org
BUG=610429,608598
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-09 23:51:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-09 23:53:21]

Description was changed from

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

Stops sections from disappearing as soon as the expand
animation begins.

R=dpapad@chromium.org
BUG=610429,608598
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Page and animation fixes

Fixes the sub-pages not expanding to 100%. Also fixes the scroll height of
main pages, which was too high due to the vertical margin (most noticeable in
About).

Stops sections from disappearing as soon as the expand
animation begins.

R=dpapad@chromium.org
BUG=610429,608598
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c
Cr-Commit-Position: refs/heads/master@{#392480}
==========

[commit-bot: I haz the power, 2016-05-09 23:53:22]

Patchset 1 (id:??) landed as
https://crrev.com/f55deb67c516167728a79cc29c7a00771c7c1b9c
Cr-Commit-Position: refs/heads/master@{#392480}