MD Settings: Fix minor vertical jumps in animations

MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

BUG=610429
R=dpapad@chromium.org

Committed: https://crrev.com/fa50bdb702230dbec1bfa0f7a830e93066056af6
Cr-Commit-Position: refs/heads/master@{#392505}

[michaelpg, 2016-05-09 23:23:49]

Description was changed from

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
==========

to

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-09 23:24:34]

Description was changed from

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

BUG=610429
R=dpapad@chromium.org
==========

[michaelpg, 2016-05-09 23:24:34]

michaelpg@chromium.org changed reviewers:
+ dpapad@chromium.org

[michaelpg, 2016-05-09 23:25:38]

PTAL.

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_subpage.html
(left):

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_subpage.html:13:
margin: 8px 0 16px 0;
This was a mistake from when I moved this from the section sub-header to this
element. It was intended to provide spacing around just the header, not the
whole subpage.

[dpapad, 2016-05-09 23:35:54]

LGTM with some suggestions.

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:297:
parseInt(getComputedStyle(section.$.header).marginBottom) +
Let's pass 10 as the 2nd parameter of parseInt(), as suggested by the
documentation at
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...,
(see "Always specify this parameter" bold text).

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:298:
parseInt(getComputedStyle(section.$.header).marginTop);
Guessing that getComputedStyles() calls are simply reading cached values (it is
not entirely clear from documentation)? If not, let's call it only once instead.

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:312:
return promise;
Nit: Inline unnecessary local var.

return this.animateElement('section', card, keyframes, options);

[michaelpg, 2016-05-10 00:36:19]

thanks!

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:297:
parseInt(getComputedStyle(section.$.header).marginBottom) +
On 2016/05/09 23:35:53, dpapad wrote:
> Let's pass 10 as the 2nd parameter of parseInt(), as suggested by the
> documentation at
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...,
> (see "Always specify this parameter" bold text).

Done.

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:298:
parseInt(getComputedStyle(section.$.header).marginTop);
On 2016/05/09 23:35:53, dpapad wrote:
> Guessing that getComputedStyles() calls are simply reading cached values (it
is
> not entirely clear from documentation)? If not, let's call it only once
instead.

Done (i thought so but i can't verify it)

https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:312:
return promise;
On 2016/05/09 23:35:53, dpapad wrote:
> Nit: Inline unnecessary local var.
> 
> return this.animateElement('section', card, keyframes, options);

Done.

[michaelpg, 2016-05-10 00:36:23]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-05-10 00:36:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1962943002/#ps20001
(title: "dpapad")

[commit-bot: I haz the power, 2016-05-10 00:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962943002/20001

[commit-bot: I haz the power, 2016-05-10 01:21:47]

Description was changed from

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

BUG=610429
R=dpapad@chromium.org
==========

to

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

BUG=610429
R=dpapad@chromium.org
==========

[commit-bot: I haz the power, 2016-05-10 01:21:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 01:23:00]

Description was changed from

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

BUG=610429
R=dpapad@chromium.org
==========

to

==========
MD Settings: Fix minor vertical jumps in animations

This fixes glitches in the section-subpage expand/collapse animations.

I wrote up a much longer description but git ate it.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

BUG=610429
R=dpapad@chromium.org

Committed: https://crrev.com/fa50bdb702230dbec1bfa0f7a830e93066056af6
Cr-Commit-Position: refs/heads/master@{#392505}
==========

[commit-bot: I haz the power, 2016-05-10 01:23:01]

Patchset 2 (id:??) landed as
https://crrev.com/fa50bdb702230dbec1bfa0f7a830e93066056af6
Cr-Commit-Position: refs/heads/master@{#392505}