Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1962943002: MD Settings: Fix minor vertical jumps in animations (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@AnimationFixes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix minor vertical jumps in animations This fixes glitches in the section-subpage expand/collapse animations. I wrote up a much longer description but git ate it. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=610429 R=dpapad@chromium.org Committed: https://crrev.com/fa50bdb702230dbec1bfa0f7a830e93066056af6 Cr-Commit-Position: refs/heads/master@{#392505}

Patch Set 1 #

Total comments: 7

Patch Set 2 : dpapad #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
michaelpg
PTAL. https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/settings/settings_page/settings_subpage.html File chrome/browser/resources/settings/settings_page/settings_subpage.html (left): https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/settings/settings_page/settings_subpage.html#oldcode13 chrome/browser/resources/settings/settings_page/settings_subpage.html:13: margin: 8px 0 16px 0; This was a ...
4 years, 7 months ago (2016-05-09 23:25:38 UTC) #4
dpapad
LGTM with some suggestions. https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js#newcode297 chrome/browser/resources/settings/settings_page/main_page_behavior.js:297: parseInt(getComputedStyle(section.$.header).marginBottom) + Let's pass 10 ...
4 years, 7 months ago (2016-05-09 23:35:54 UTC) #5
michaelpg
thanks! https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/1962943002/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js#newcode297 chrome/browser/resources/settings/settings_page/main_page_behavior.js:297: parseInt(getComputedStyle(section.$.header).marginBottom) + On 2016/05/09 23:35:53, dpapad wrote: > ...
4 years, 7 months ago (2016-05-10 00:36:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962943002/20001
4 years, 7 months ago (2016-05-10 00:36:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 01:21:48 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 01:23:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa50bdb702230dbec1bfa0f7a830e93066056af6
Cr-Commit-Position: refs/heads/master@{#392505}

Powered by Google App Engine
This is Rietveld 408576698