chrome/browser/resources/settings/settings_page/main_page_behavior.html - Issue 1965553002: MD Settings: Page and animation fixes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.html

Issue 1965553002: MD Settings: Page and animation fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page.css ('k') | chrome/browser/resources/settings/settings_page/settings_animated_pages.js » ('j') | chrome/browser/resources/settings/settings_page/settings_animated_pages.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://md-settings/settings_page/transition_behavior. html">	2 <link rel="import" href="chrome://md-settings/settings_page/transition_behavior. html">

3 <script src="chrome://md-settings/settings_page/main_page_behavior.js"></script>	3 <script src="chrome://md-settings/settings_page/main_page_behavior.js"></script>

4	4

5 <dom-module id="main-page-styles">	5 <dom-module id="main-page-styles">

6 <template>	6 <template>

7 <style>	7 <style>

8 .expanding,	8 .expanding,

9 .collapsing {	9 .collapsing {

10 z-index: 2;	10 z-index: 2;

11 }	11 }

12	12

13 .expanded {	13 .expanded {

14 min-height: 100%;	14 min-height: 100%;

15 }	15 }

	16

	17 .expanded.frozen {

	18 /* Account for padding in settings_page.css. */

	19 margin: -24px 0;

	20 min-height: calc(100% + 48px);
	michaelpg 2016/05/09 21:24:47 this is slightly unfortunate, but it works. we sh this is slightly unfortunate, but it works. we should combine these styles with settings_page.css anyway, so at least these magic numbers will be in the same place. dpapad 2016/05/09 21:34:58 This indeed seems like magic, so I trust you that Show quoted text On 2016/05/09 at 21:24:47, michaelpg wrote: > this is slightly unfortunate, but it works. > > we should combine these styles with settings_page.css anyway, > so at least these magic numbers will be in the same place. This indeed seems like magic, so I trust you that it works, and +1 on cleaning this up to make it less cryptic.
	21 }

16 </style>	22 </style>

17 </template>	23 </template>

18 </dom-module>	24 </dom-module>

OLD	NEW