Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1965413003: Save federated credential's signon_realm in the correct format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 4490457e521f086be707d5e3c198499421189033..482f17061da1f8dbe12d3dd55a551fe98d3df338 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -1153,6 +1153,8 @@ void PasswordFormManager::CreatePendingCredentials() {
pending_credentials_.federation_origin =
provisionally_saved_form_->federation_origin;
pending_credentials_.icon_url = provisionally_saved_form_->icon_url;
+ // Take the correct signon_realm for federated credentials.
+ pending_credentials_.signon_realm = provisionally_saved_form_->signon_realm;
}
if (user_action_ == kUserActionOverridePassword &&
« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698