Issue 196533014: Only report number of retained methods if we actually find an import of mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196533014: Only report number of retained methods if we actually find an import of mirrors. (Closed)

Created:
6 years, 9 months ago by karlklose

Modified:
6 years, 5 months ago

Reviewers:
ahe, floitsch, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only report number of retained methods if we actually find an import of mirrors. This does not really solve the issue that the reported number is too high, but it stops reporting the number in case that there is no import, which is confusing. R=ahe@google.com BUG= http://dartbug.com/17457

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		2 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

How about we fix the problem instead? I was looking for you a few times ...

6 years, 9 months ago (2014-03-14 07:58:24 UTC) #3

sra1

6 years, 6 months ago (2014-06-20 21:08:06 UTC) #4

I have a better fix which is to count the retained methods correctly -
https://codereview.chromium.org/340253003/

Please abandon this CL

Expand Messages | Collapse Messages