Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1730)

Issue 340253003: Avoid counting custom elements as added due to mirrors (Closed)

Created:
6 years, 6 months ago by sra1
Modified:
6 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Avoid counting custom elements as added due to mirrors Fixes issue 17470 BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=37624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
I believe this fixes the bogus hint as we discussed.
6 years, 6 months ago (2014-06-20 21:14:29 UTC) #1
sra1
On 2014/06/20 21:14:29, sra1 wrote: > I believe this fixes the bogus hint as we ...
6 years, 6 months ago (2014-06-20 21:15:21 UTC) #2
ahe
LGTM!
6 years, 6 months ago (2014-06-23 11:57:15 UTC) #3
sra1
6 years, 6 months ago (2014-06-23 21:56:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698