Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964953002: Add rights for mapping buffer. Update (shared) buffer APIs. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work787_edk_handle_14.4
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -21 lines) Patch
M mojo/edk/system/core.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/handle_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/c/system/buffer.h View 7 chunks +27 lines, -13 lines 0 comments Download
M mojo/public/c/system/handle.h View 3 chunks +10 lines, -0 lines 1 comment Download

Depends on Patchset:

Issue 1963053003 Patch 1

Messages

Total messages: 5 (1 generated)
viettrungluu
(Depends on https://codereview.chromium.org/1963053003/.)
4 years, 7 months ago (2016-05-10 18:07:33 UTC) #1
azani
lgtm https://codereview.chromium.org/1964953002/diff/1/mojo/public/c/system/handle.h File mojo/public/c/system/handle.h (right): https://codereview.chromium.org/1964953002/diff/1/mojo/public/c/system/handle.h#newcode91 mojo/public/c/system/handle.h:91: Nit: did you mean to add that extra ...
4 years, 7 months ago (2016-05-10 18:44:50 UTC) #2
viettrungluu
Thanks. On 2016/05/10 18:44:50, azani wrote: > lgtm > > https://codereview.chromium.org/1964953002/diff/1/mojo/public/c/system/handle.h > File mojo/public/c/system/handle.h (right): ...
4 years, 7 months ago (2016-05-10 19:30:47 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-10 19:31:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b5f7a2ab16fc874d382fd877b14e0920ecafe785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698