mojo/edk/system/shared_buffer_dispatcher.h - Issue 1964953002: Add rights for mapping buffer. Update (shared) buffer APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/shared_buffer_dispatcher.h

Issue 1964953002: Add rights for mapping buffer. Update (shared) buffer APIs. (Closed) Base URL: https://github.com/domokit/mojo.git@work787_edk_handle_14.4

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/shared_buffer_dispatcher.h

diff --git a/mojo/edk/system/shared_buffer_dispatcher.h b/mojo/edk/system/shared_buffer_dispatcher.h

index 70e21581e396c9fad8a14ee448e251fdc761c1f3..68c3209b24fd074f0852d799c62d54f28fbcd229 100644

--- a/mojo/edk/system/shared_buffer_dispatcher.h

+++ b/mojo/edk/system/shared_buffer_dispatcher.h

@@ -36,7 +36,9 @@ class SharedBufferDispatcher final : public SimpleDispatcher {

// duplicable by default.

static constexpr MojoHandleRights kDefaultHandleRights =

MOJO_HANDLE_RIGHT_DUPLICATE | MOJO_HANDLE_RIGHT_TRANSFER |

- MOJO_HANDLE_RIGHT_READ | MOJO_HANDLE_RIGHT_WRITE;

+ MOJO_HANDLE_RIGHT_GET_OPTIONS | MOJO_HANDLE_RIGHT_SET_OPTIONS |

+ MOJO_HANDLE_RIGHT_MAP_READABLE | MOJO_HANDLE_RIGHT_MAP_WRITABLE |

+ MOJO_HANDLE_RIGHT_MAP_EXECUTABLE;

// The default options to use for |MojoCreateSharedBuffer()|. (Real uses

// should obtain this via |ValidateCreateOptions()| with a null |in_options|;

« no previous file with comments | « mojo/edk/system/handle_unittest.cc ('k') | mojo/public/c/system/buffer.h » ('j') | mojo/public/c/system/handle.h » ('J')