Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1963053003: Add rights for get/set options. Update message pipe and data pipe APIs. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add rights for get/set options. Update message pipe and data pipe APIs. Rationale for having separate get/set options rights: Otherwise, you can control the abilities to read from a data pipe consumer and set its options independently, but the abilities to write to a data pipe producer and set its options are tied to a single right. Still to do separately: I still have to update docs for other APIs. Also, I can't really test these in a reasonable way until I've implemented MojoGetRights() and MojoReduceRights(). R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/67c8e97e69bf3e4782adfa2cf2c15f336d6a0986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -64 lines) Patch
M mojo/edk/system/core.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/handle_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/c/system/data_pipe.h View 21 chunks +64 lines, -32 lines 0 comments Download
M mojo/public/c/system/handle.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/public/c/system/message_pipe.h View 4 chunks +23 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-10 17:23:32 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-10 18:41:52 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-10 19:30:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
67c8e97e69bf3e4782adfa2cf2c15f336d6a0986 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698