A64: Handle a few TODOs.

A64: Handle a few TODOs.

Below are notes about some of the TODOs handled.

* In Simulator::Debug:
    We haven't had issues with printing in the debugger for a while. If the
    feature turns out to be still lacking an issue can be raised.

* In SubStringStub::Generate:
    There is no need to jump there. The StringCharAtGenerator is asked to set
    the result in x0, and the return sequence following only uses two instructions.
    Also, we would need to jump after the native counter increment instead of the
    return_x0 label.

* In ArrayPushStub::Generate:
    Raised an internal issue to check and update the ARM code.

* In MacroAssembler::CopyBytes:
    The new code should be faster for bulk copies. Raised an internal issue to
    investigate and improve this function.

* In MacroAssembler::EnterExitFrame:
    Unless we actually find something is wrong, this is working and looks ok.
    Also fixed the comments about the FP registers.

* Comment for BumpSystemStackPointer:
    Removed the comment at the declaration site and updated the TODO in the
    implementation.

R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20034

[ulan, 2014-03-18 12:51:14]

LGTM

In future could you please split unrelated changes into different CLs? It is
much easier to review n CLs of size m than one CL of size n*m. =)

https://codereview.chromium.org/196473021/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):

https://codereview.chromium.org/196473021/diff/1/src/a64/macro-assembler-a64....
src/a64/macro-assembler-a64.cc:2467: Cbz(bulk_length, &short_copy);
You probably wanted to use flags set by Bics.

[Alexandre Rames, 2014-03-18 13:35:23]

I will split the next TODOs into separate patches. We did so to avoid the review
cycle overhead as there are quite a few.

https://codereview.chromium.org/196473021/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):

https://codereview.chromium.org/196473021/diff/1/src/a64/macro-assembler-a64....
src/a64/macro-assembler-a64.cc:2467: Cbz(bulk_length, &short_copy);
On 2014/03/18 12:51:14, ulan wrote:
> You probably wanted to use flags set by Bics.

Yes. Fixed that.

[Alexandre Rames, 2014-03-18 13:53:50]

>
https://codereview.chromium.org/196473021/diff/1/src/a64/macro-assembler-a64....
> src/a64/macro-assembler-a64.cc:2467: Cbz(bulk_length, &short_copy);
> On 2014/03/18 12:51:14, ulan wrote:
> > You probably wanted to use flags set by Bics.
> 
> Yes. Fixed that.

Actually, following our current rule of thumb, we prefer not setting the flags
with BIC, and using CBZ.

[Alexandre Rames, 2014-03-18 14:00:30]

Committed patchset #1 manually as r20034 (presubmit successful).