Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/a64/macro-assembler-a64-inl.h

Issue 196473021: A64: Handle a few TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1266 ASSERT(allow_macro_instructions_); 1266 ASSERT(allow_macro_instructions_);
1267 ASSERT(!rd.IsZero()); 1267 ASSERT(!rd.IsZero());
1268 uxtw(rd, rn); 1268 uxtw(rd, rn);
1269 } 1269 }
1270 1270
1271 1271
1272 void MacroAssembler::BumpSystemStackPointer(const Operand& space) { 1272 void MacroAssembler::BumpSystemStackPointer(const Operand& space) {
1273 ASSERT(!csp.Is(sp_)); 1273 ASSERT(!csp.Is(sp_));
1274 // TODO(jbramley): Several callers rely on this not using scratch registers, 1274 // TODO(jbramley): Several callers rely on this not using scratch registers,
1275 // so we use the assembler directly here. However, this means that large 1275 // so we use the assembler directly here. However, this means that large
1276 // immediate values of 'space' cannot be handled cleanly. Once we implement 1276 // immediate values of 'space' cannot be handled cleanly. (Only 24-bits
1277 // our flexible scratch register idea, we could greatly simplify this 1277 // immediates or values of 'space' that can be encoded in one instruction are
1278 // function. 1278 // accepted.) Once we implement our flexible scratch register idea, we could
1279 // greatly simplify this function.
1279 InstructionAccurateScope scope(this); 1280 InstructionAccurateScope scope(this);
1280 if ((space.IsImmediate()) && !is_uint12(space.immediate())) { 1281 if ((space.IsImmediate()) && !is_uint12(space.immediate())) {
1281 // The subtract instruction supports a 12-bit immediate, shifted left by 1282 // The subtract instruction supports a 12-bit immediate, shifted left by
1282 // zero or 12 bits. So, in two instructions, we can subtract any immediate 1283 // zero or 12 bits. So, in two instructions, we can subtract any immediate
1283 // between zero and (1 << 24) - 1. 1284 // between zero and (1 << 24) - 1.
1284 int64_t imm = space.immediate(); 1285 int64_t imm = space.immediate();
1285 ASSERT(is_uint24(imm)); 1286 ASSERT(is_uint24(imm));
1286 1287
1287 int64_t imm_top_12_bits = imm >> 12; 1288 int64_t imm_top_12_bits = imm >> 12;
1288 sub(csp, StackPointer(), imm_top_12_bits << 12); 1289 sub(csp, StackPointer(), imm_top_12_bits << 12);
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
1667 // characters are reserved for controlling features of the instrumentation. 1668 // characters are reserved for controlling features of the instrumentation.
1668 ASSERT(isprint(marker_name[0]) && isprint(marker_name[1])); 1669 ASSERT(isprint(marker_name[0]) && isprint(marker_name[1]));
1669 1670
1670 InstructionAccurateScope scope(this, 1); 1671 InstructionAccurateScope scope(this, 1);
1671 movn(xzr, (marker_name[1] << 8) | marker_name[0]); 1672 movn(xzr, (marker_name[1] << 8) | marker_name[0]);
1672 } 1673 }
1673 1674
1674 } } // namespace v8::internal 1675 } } // namespace v8::internal
1675 1676
1676 #endif // V8_A64_MACRO_ASSEMBLER_A64_INL_H_ 1677 #endif // V8_A64_MACRO_ASSEMBLER_A64_INL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698