Make the Dart application library code stop using the "wrong way" service provider (a.k.a. exposed_…

Make the Dart application library code stop using the "wrong way" service provider (a.k.a. exposed_services).

The plan is to get rid of exposed_services.

No one is *really* using exposed_services now anyway (now that tracing
no longer uses it).

So we can make connectToApplication() not bring up exposed_services.
Probably things could be refactored/cleaned up significantly once
exposed_services is gone.

(Note that some of the existing code was dubious: exposed_services is
optional, so blindly calling close() on a proxy for it was wrong.)

R=johnmccutchan@google.com, zra@google.com
BUG=#762

Committed: https://chromium.googlesource.com/external/mojo/+/a0a2c0472e017cb7cc85a48bf3cde804c67963de

[viettrungluu, 2016-05-09 19:19:46]

https://codereview.chromium.org/1964623002/diff/1/examples/dart/hello_world/h...
File examples/dart/hello_world/hello/lib/main.dart (right):

https://codereview.chromium.org/1964623002/diff/1/examples/dart/hello_world/h...
examples/dart/hello_world/hello/lib/main.dart:32:
c.remoteServiceProvider.impl.onError = closeApplication;
Since we no longer provide exposed_services, we can't detect errors on its stub.
We can detect errors on the proxy (for the ServiceProvider in the other, usual,
way) though. I'm not sure what the best way is to do this....

[Cutch, 2016-05-09 20:46:01]

johnmccutchan@google.com changed reviewers:
+ zra@google.com

[Cutch, 2016-05-09 20:46:02]

LGTM but I've brought Zach on to review it as well.

[zra, 2016-05-09 21:12:12]

lgtm

https://codereview.chromium.org/1964623002/diff/1/examples/dart/hello_world/h...
File examples/dart/hello_world/hello/lib/main.dart (right):

https://codereview.chromium.org/1964623002/diff/1/examples/dart/hello_world/h...
examples/dart/hello_world/hello/lib/main.dart:32:
c.remoteServiceProvider.impl.onError = closeApplication;
On 2016/05/09 19:19:46, viettrungluu wrote:
> Since we no longer provide exposed_services, we can't detect errors on its
stub.
> We can detect errors on the proxy (for the ServiceProvider in the other,
usual,
> way) though. I'm not sure what the best way is to do this....

I don't think there's a better way to do this right now. We should make this
easier when ApplicationConnection is cleaned up.

[viettrungluu, 2016-05-09 21:24:32]

Description was changed from

==========
Make the Dart application library code stop using the "wrong way" service
provider (a.k.a. exposed_services).

The plan is to get rid of exposed_services.

No one is *really* using exposed_services now anyway (now that tracing
no longer uses it).

So we can make connectToApplication() not bring up exposed_services.
Probably things could be refactored/cleaned up significantly once
exposed_services is gone.

(Note that some of the existing code was dubious: exposed_services is
optional, so blindly calling close() on a proxy for it was wrong.)

R=johnmccutchan@google.com
BUG=#762
==========

to

==========
Make the Dart application library code stop using the "wrong way" service
provider (a.k.a. exposed_services).

The plan is to get rid of exposed_services.

No one is *really* using exposed_services now anyway (now that tracing
no longer uses it).

So we can make connectToApplication() not bring up exposed_services.
Probably things could be refactored/cleaned up significantly once
exposed_services is gone.

(Note that some of the existing code was dubious: exposed_services is
optional, so blindly calling close() on a proxy for it was wrong.)

R=johnmccutchan@google.com, zra@google.com
BUG=#762

Committed:
https://chromium.googlesource.com/external/mojo/+/a0a2c0472e017cb7cc85a48bf3c...
==========

[viettrungluu, 2016-05-09 21:24:34]

Committed patchset #1 (id:1) manually as
a0a2c0472e017cb7cc85a48bf3cde804c67963de (presubmit successful).