mojo/dart/packages/mojo/lib/src/application.dart - Issue 1964623002: Make the Dart application library code stop using the "wrong way" service provider (a.k.a. exposed_…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/mojo/lib/src/application.dart

Issue 1964623002: Make the Dart application library code stop using the "wrong way" service provider (a.k.a. exposed_… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« examples/dart/hello_world/hello/lib/main.dart ('K') | « mojo/dart/apptests/test_apps/pingpong_target/lib/main.dart ('k') | mojo/dart/packages/mojo/lib/src/application_connection.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/mojo/lib/src/application.dart

diff --git a/mojo/dart/packages/mojo/lib/src/application.dart b/mojo/dart/packages/mojo/lib/src/application.dart

index 885996f51f4553b55033d700280b527b6b50f463..488127f602557c56e65470f6c6763353d6480deb 100644

--- a/mojo/dart/packages/mojo/lib/src/application.dart

+++ b/mojo/dart/packages/mojo/lib/src/application.dart

@@ -97,9 +97,8 @@ abstract class Application implements bindings.ServiceConnector {

// Returns a connection to the app at |url|.

ApplicationConnection connectToApplication(String url) {

var proxy = new ServiceProviderProxy.unbound();

- var stub = new ServiceProviderStub.unbound();

- _applicationImpl.shell.ptr.connectToApplication(url, proxy, stub);

- var connection = new ApplicationConnection(stub, proxy);

+ _applicationImpl.shell.ptr.connectToApplication(url, proxy, null);

+ var connection = new ApplicationConnection(null, proxy);

_applicationConnections.add(connection);

return connection;

}