Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: mojo/dart/packages/mojo/lib/src/application_connection.dart

Issue 1964623002: Make the Dart application library code stop using the "wrong way" service provider (a.k.a. exposed_… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo/lib/src/application_connection.dart
diff --git a/mojo/dart/packages/mojo/lib/src/application_connection.dart b/mojo/dart/packages/mojo/lib/src/application_connection.dart
index ad0dbb04694666bd27775f82cae8bd9188f52f30..cb89b91ec73582abba02fc306e06ad65542b1bb4 100644
--- a/mojo/dart/packages/mojo/lib/src/application_connection.dart
+++ b/mojo/dart/packages/mojo/lib/src/application_connection.dart
@@ -62,6 +62,9 @@ class LocalServiceProvider implements ServiceProvider {
/// To handle requests for services beyond those set up with [provideService],
/// set [fallbackServiceFactory] to a function that instantiates a service as in
/// the [provideService] case, or closes the pipe.
+// TODO(vtl): Once "exposed_services" is removed from Shell's
+// ConnectToApplication() (and Application's AcceptConnection(), etc.), this
+// class will be a bit of overkill. https://github.com/domokit/mojo/issues/762
class ApplicationConnection {
ServiceProviderProxy remoteServiceProvider;
LocalServiceProvider _localServiceProvider;

Powered by Google App Engine
This is Rietveld 408576698