Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1964473003: Set orphans and widows to 1 in lots-of-text-balanced multicol performance test. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set orphans and widows to 1 in lots-of-text-balanced multicol performance test. https://codereview.chromium.org/1909233002 changed the initial values for orphans and widows to match the spec. This could very well affect performance slightly, although I cannot reproduce it myself. Speculatively set orphans/widows to 1 and see if that helps. Add a new test that uses higher values for orphans and widows, so that we still get to test that too. BUG=606262 Committed: https://crrev.com/e1665788d89da9aeeb80ee6b2e0a9c8c65fbce08 Cr-Commit-Position: refs/heads/master@{#392625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/PerformanceTests/Layout/multicol/lots-of-text-balanced.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/PerformanceTests/Layout/multicol/lots-of-text-balanced-orphans-widows.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 08:29:42 UTC) #2
eae
Ok, LGTM
4 years, 7 months ago (2016-05-10 15:34:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964473003/1
4 years, 7 months ago (2016-05-10 15:34:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 16:38:54 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 16:41:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1665788d89da9aeeb80ee6b2e0a9c8c65fbce08
Cr-Commit-Position: refs/heads/master@{#392625}

Powered by Google App Engine
This is Rietveld 408576698