Replace setMatrixClip() with BeginPlatformPaint() logic

Replace setMatrixClip() with BeginPlatformPaint() logic

Instead of storing the current transform and clip every time
SkCanvas::DeviceCM::setMatrixClip() is called, query the
current transform and clip in skia::BeginPlatformPaint() and
propagate them to the device subsequently.

Removes some state that was being stored on BitmapPlatformDevice
and a dependency on a to-be-deprected internal Skia function;
takes advantage of our recent discovery that no platform was
using complex clips and we can just use the clip bounds.

Gets rid of some lazy caching of unknown performance impact.

R=reed@google.com
BUG=609894
Committed: https://crrev.com/c7aaa19ef205902d338508cdf2697724c7b4872a
Cr-Commit-Position: refs/heads/master@{#394757}

[tomhudson, 2016-05-09 15:30:20]

Mike: this'll get rid of setMatrixClip(), but requires exposing getTotalClip().
Ugh? How best to plumb through?

[tomhudson, 2016-05-11 11:51:18]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[tomhudson, 2016-05-11 11:51:30]

Description was changed from

==========
Replace setMatrixClip() with BeginPlatformPaint() logic

Instead of storing the current transform and clip every time
SkCanvas::DeviceCM::setMatrixClip() is called, query the
current transform and clip in skia::BeginPlatformPaint() and
propagate them to the

Removes some state that was being stored on BitmapPlatformDevice
and a dependency on a to-be-deprected internal Skia function,
in exchange for undeprecating another internal Skia function and
getting rid of some lazy caching of unknown performance impact.

R=reed@google.com
BUG=609894
==========

to

==========
Replace setMatrixClip() with BeginPlatformPaint() logic

Instead of storing the current transform and clip every time
SkCanvas::DeviceCM::setMatrixClip() is called, query the
current transform and clip in skia::BeginPlatformPaint() and
propagate them to the device subsequently.

Removes some state that was being stored on BitmapPlatformDevice
and a dependency on a to-be-deprected internal Skia function;
takes advantage of our recent discovery that no platform was
using complex clips and we can just use the clip bounds.

Gets rid of some lazy caching of unknown performance impact.

R=reed@google.com
BUG=609894
==========

[commit-bot: I haz the power, 2016-05-11 11:51:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963713002/20001

[commit-bot: I haz the power, 2016-05-11 12:00:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 12:00:06]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tomhudson, 2016-05-11 12:27:58]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 12:28:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963713002/40001

[commit-bot: I haz the power, 2016-05-11 12:36:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 12:36:29]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[tomhudson, 2016-05-11 13:01:10]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 13:01:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963713002/60001

[commit-bot: I haz the power, 2016-05-11 13:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 13:13:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[tomhudson, 2016-05-11 17:05:11]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 17:05:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963713002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963713002/120001

[tomhudson, 2016-05-11 17:47:18]

On 2016/05/11 17:05:30, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1963713002/120001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1963713002/120001

[tomhudson, 2016-05-11 17:48:23]

tomhudson@google.com changed reviewers:
+ fmalita@chromium.org

[tomhudson, 2016-05-11 17:48:24]

Looks like the bots are happy. There's some performance risk with this one, but
I think it'll be a wash in the end. What did I miss?

(+Florin)

[reed1, 2016-05-11 17:52:55]

lgtm

[commit-bot: I haz the power, 2016-05-11 18:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 18:06:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[f(malita), 2016-05-11 19:29:37]

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/bitmap_platfo...
File skia/ext/bitmap_platform_device_mac_unittest.cc (right):

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/bitmap_platfo...
skia/ext/bitmap_platform_device_mac_unittest.cc:35: SkCanvas* canvas =
skia::CreateCanvas(bitmap_, CRASH_ON_FAILURE);
Looks like this will leak.  sk_sp<SkCanvas> instead?

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/bitmap_platfo...
skia/ext/bitmap_platform_device_mac_unittest.cc:53: SkCanvas* canvas =
skia::CreateCanvas(bitmap_, CRASH_ON_FAILURE);
Ditto.

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/skia_utils_ma...
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/skia_utils_ma...
skia/ext/skia_utils_mac.mm:197: SkCanvas* canvas = skia::CreateCanvas(device,
RETURN_NULL_ON_FAILURE);
Ditto.

[tomhudson, 2016-05-19 12:24:12]

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/bitmap_platfo...
File skia/ext/bitmap_platform_device_mac_unittest.cc (right):

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/bitmap_platfo...
skia/ext/bitmap_platform_device_mac_unittest.cc:35: SkCanvas* canvas =
skia::CreateCanvas(bitmap_, CRASH_ON_FAILURE);
On 2016/05/11 19:29:37, f(malita) wrote:
> Looks like this will leak.  sk_sp<SkCanvas> instead?

Done.

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/bitmap_platfo...
skia/ext/bitmap_platform_device_mac_unittest.cc:53: SkCanvas* canvas =
skia::CreateCanvas(bitmap_, CRASH_ON_FAILURE);
On 2016/05/11 19:29:37, f(malita) wrote:
> Ditto.

Done.

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/skia_utils_ma...
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/1963713002/diff/120001/skia/ext/skia_utils_ma...
skia/ext/skia_utils_mac.mm:197: SkCanvas* canvas = skia::CreateCanvas(device,
RETURN_NULL_ON_FAILURE);
On 2016/05/11 19:29:37, f(malita) wrote:
> Ditto.

Done.

[tomhudson, 2016-05-19 12:24:19]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 12:24:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963713002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963713002/160001

[commit-bot: I haz the power, 2016-05-19 13:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 13:27:36]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-05-19 13:29:41]

With our Skia changes this passes the bots.

[f(malita), 2016-05-19 13:36:56]

lgtm

[tomhudson, 2016-05-19 13:38:13]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-05-19 13:38:14]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1963713002/#ps160001
(title: "compensate for any outstanding saveLayer() calls")

[commit-bot: I haz the power, 2016-05-19 13:38:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963713002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963713002/160001

[commit-bot: I haz the power, 2016-05-19 13:41:59]

Description was changed from

==========
Replace setMatrixClip() with BeginPlatformPaint() logic

Instead of storing the current transform and clip every time
SkCanvas::DeviceCM::setMatrixClip() is called, query the
current transform and clip in skia::BeginPlatformPaint() and
propagate them to the device subsequently.

Removes some state that was being stored on BitmapPlatformDevice
and a dependency on a to-be-deprected internal Skia function;
takes advantage of our recent discovery that no platform was
using complex clips and we can just use the clip bounds.

Gets rid of some lazy caching of unknown performance impact.

R=reed@google.com
BUG=609894
==========

to

==========
Replace setMatrixClip() with BeginPlatformPaint() logic

Instead of storing the current transform and clip every time
SkCanvas::DeviceCM::setMatrixClip() is called, query the
current transform and clip in skia::BeginPlatformPaint() and
propagate them to the device subsequently.

Removes some state that was being stored on BitmapPlatformDevice
and a dependency on a to-be-deprected internal Skia function;
takes advantage of our recent discovery that no platform was
using complex clips and we can just use the clip bounds.

Gets rid of some lazy caching of unknown performance impact.

R=reed@google.com
BUG=609894
==========

[commit-bot: I haz the power, 2016-05-19 13:42:00]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-05-19 13:44:33]

Description was changed from

==========
Replace setMatrixClip() with BeginPlatformPaint() logic

Instead of storing the current transform and clip every time
SkCanvas::DeviceCM::setMatrixClip() is called, query the
current transform and clip in skia::BeginPlatformPaint() and
propagate them to the device subsequently.

Removes some state that was being stored on BitmapPlatformDevice
and a dependency on a to-be-deprected internal Skia function;
takes advantage of our recent discovery that no platform was
using complex clips and we can just use the clip bounds.

Gets rid of some lazy caching of unknown performance impact.

R=reed@google.com
BUG=609894
==========

to

==========
Replace setMatrixClip() with BeginPlatformPaint() logic

Instead of storing the current transform and clip every time
SkCanvas::DeviceCM::setMatrixClip() is called, query the
current transform and clip in skia::BeginPlatformPaint() and
propagate them to the device subsequently.

Removes some state that was being stored on BitmapPlatformDevice
and a dependency on a to-be-deprected internal Skia function;
takes advantage of our recent discovery that no platform was
using complex clips and we can just use the clip bounds.

Gets rid of some lazy caching of unknown performance impact.

R=reed@google.com
BUG=609894

Committed: https://crrev.com/c7aaa19ef205902d338508cdf2697724c7b4872a
Cr-Commit-Position: refs/heads/master@{#394757}
==========

[commit-bot: I haz the power, 2016-05-19 13:44:35]

Patchset 9 (id:??) landed as
https://crrev.com/c7aaa19ef205902d338508cdf2697724c7b4872a
Cr-Commit-Position: refs/heads/master@{#394757}