Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: skia/ext/bitmap_platform_device_skia.cc

Issue 1963713002: Replace setMatrixClip() with BeginPlatformPaint() logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compensate for any outstanding saveLayer() calls Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « skia/ext/bitmap_platform_device_skia.h ('k') | skia/ext/bitmap_platform_device_win.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "skia/ext/bitmap_platform_device_skia.h" 5 #include "skia/ext/bitmap_platform_device_skia.h"
6 #include "skia/ext/platform_canvas.h" 6 #include "skia/ext/platform_canvas.h"
7 7
8 namespace skia { 8 namespace skia {
9 9
10 BitmapPlatformDevice* BitmapPlatformDevice::Create(int width, int height, 10 BitmapPlatformDevice* BitmapPlatformDevice::Create(int width, int height,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 BitmapPlatformDevice::~BitmapPlatformDevice() { 42 BitmapPlatformDevice::~BitmapPlatformDevice() {
43 } 43 }
44 44
45 SkBaseDevice* BitmapPlatformDevice::onCreateDevice(const CreateInfo& info, 45 SkBaseDevice* BitmapPlatformDevice::onCreateDevice(const CreateInfo& info,
46 const SkPaint*) { 46 const SkPaint*) {
47 SkASSERT(info.fInfo.colorType() == kN32_SkColorType); 47 SkASSERT(info.fInfo.colorType() == kN32_SkColorType);
48 return BitmapPlatformDevice::Create(info.fInfo.width(), info.fInfo.height(), 48 return BitmapPlatformDevice::Create(info.fInfo.width(), info.fInfo.height(),
49 info.fInfo.isOpaque()); 49 info.fInfo.isOpaque());
50 } 50 }
51 51
52 PlatformSurface BitmapPlatformDevice::BeginPlatformPaint() { 52 PlatformSurface BitmapPlatformDevice::BeginPlatformPaint(const SkMatrix& transfo rm,
53 const SkIRect& clip_bou nds) {
54 // TODO(tomhudson): propagate transform and clip
53 // TODO(zhenghao): What should we return? The ptr to the address of the 55 // TODO(zhenghao): What should we return? The ptr to the address of the
54 // pixels? Maybe this won't be called at all. 56 // pixels? Maybe this won't be called at all.
55 return accessBitmap(true).getPixels(); 57 return accessBitmap(true).getPixels();
56 } 58 }
57 59
58 // PlatformCanvas impl 60 // PlatformCanvas impl
59 61
60 SkCanvas* CreatePlatformCanvas(int width, int height, bool is_opaque, 62 SkCanvas* CreatePlatformCanvas(int width, int height, bool is_opaque,
61 uint8_t* data, OnFailureType failureType) { 63 uint8_t* data, OnFailureType failureType) {
62 sk_sp<SkBaseDevice> dev( 64 sk_sp<SkBaseDevice> dev(
63 BitmapPlatformDevice::Create(width, height, is_opaque, data)); 65 BitmapPlatformDevice::Create(width, height, is_opaque, data));
64 return CreateCanvas(dev, failureType); 66 return CreateCanvas(dev, failureType);
65 } 67 }
66 68
67 } // namespace skia 69 } // namespace skia
OLDNEW
« no previous file with comments | « skia/ext/bitmap_platform_device_skia.h ('k') | skia/ext/bitmap_platform_device_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698