chrome/installer/util/google_chrome_distribution.cc - Issue 1963373003: Revert of Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 1963373003: Revert of Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index b840487428ee192fe92ca123dbd3707ca5f69470..2d7524ffea083a46fe6b67946ef42dc82687051e 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -22,7 +22,6 @@

#include "base/win/windows_version.h"

#include "chrome/common/chrome_icon_resources_win.h"

#include "chrome/common/chrome_paths_internal.h"

-#include "chrome/install_static/install_util.h"

#include "chrome/installer/util/app_registration_data.h"

#include "chrome/installer/util/channel_info.h"

#include "chrome/installer/util/google_update_constants.h"

@@ -251,9 +250,7 @@

// Crash client id.

base::FilePath crash_dir;

- base::string16 crash_dump_location;

- if (install_static::GetDefaultCrashDumpLocation(&crash_dump_location)) {

- crash_dir = base::FilePath(crash_dump_location);

+ if (chrome::GetDefaultCrashDumpLocation(&crash_dir)) {

crashpad::UUID client_id;

std::unique_ptr<crashpad::CrashReportDatabase> database(

crashpad::CrashReportDatabase::InitializeWithoutCreating(crash_dir));

« no previous file with comments | « chrome/installer/util/DEPS ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »