Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1962993002: Fix odd size and visible rect issues in CanvasCaptureHandler (Closed)

Created:
4 years, 7 months ago by emircan
Modified:
4 years, 7 months ago
Reviewers:
mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix odd size and visible rect issues in CanvasCaptureHandler This CL addresses odd size frame problems found by fuzz tests. BUG=606185 TEST=Minimized fuzz test case now passes. Also added unit tests. Review URL: https://codereview.chromium.org/1918073003 Cr-Commit-Position: refs/heads/master@{#389899} (cherry picked from commit e0dd9f840b3a21cd12bd3d83f5ca63302549dd21) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -42 lines) Patch
M content/renderer/media/canvas_capture_handler.cc View 2 chunks +20 lines, -18 lines 0 comments Download
M content/renderer/media/canvas_capture_handler_unittest.cc View 7 chunks +43 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
emircan
Merging to the branch: https://bugs.chromium.org/p/chromium/issues/detail?id=606185 PTAL.
4 years, 7 months ago (2016-05-10 01:14:15 UTC) #2
mcasas
On 2016/05/10 01:14:15, emircan wrote: > Merging to the branch: > https://bugs.chromium.org/p/chromium/issues/detail?id=606185 > > PTAL. ...
4 years, 7 months ago (2016-05-10 14:56:23 UTC) #3
emircan
Thanks. Yes, adding those lines now and commit.
4 years, 7 months ago (2016-05-10 17:16:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962993002/1
4 years, 7 months ago (2016-05-10 17:16:41 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 17:19:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698