Fix odd size and visible rect issues in CanvasCaptureHandler

Fix odd size and visible rect issues in CanvasCaptureHandler

This CL addresses odd size frame problems found by fuzz tests.

BUG=606185
TEST=Minimized fuzz test case now passes. Also added unit tests.

Committed: https://crrev.com/e0dd9f840b3a21cd12bd3d83f5ca63302549dd21
Cr-Commit-Position: refs/heads/master@{#389899}

[emircan, 2016-04-25 23:46:37]

Description was changed from

==========
Fix canvas odds.

BUG=
==========

to

==========
Fix odd size and visible rect issues in CanvasCaptureHandler

This CL addresses odd size frame problems found by fuzz tests.

BUG=606185
TEST=Minimized fuzz test case now passes. Also added unit tests.
==========

[emircan, 2016-04-25 23:46:37]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org

[emircan, 2016-04-25 23:46:49]

PTAL.

[mcasas, 2016-04-26 00:07:14]

lgtm

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
File content/renderer/media/canvas_capture_handler.cc (right):

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
content/renderer/media/canvas_capture_handler.cc:29: const
scoped_refptr<media::VideoFrame>& dest_frame) {
nit: Since there's a few media::VideoFrame,
consider adding a 
using media::VideoFrame; 
around l.25, which would make this easier
to grok.

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
content/renderer/media/canvas_capture_handler.cc:45: pixel_index += 4)
ultra-nit: s/pixel_index/pixel/ ?

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
File content/renderer/media/canvas_capture_handler_unittest.cc (right):

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
content/renderer/media/canvas_capture_handler_unittest.cc:88: const int offset =
odd_size ? kTestCanvasOddSizeOffset : 0;
I'd say: Just use an integer parameter for the test (call it
|extra_misalignment| or something like that here)
as a test parameter and avoid the extra conversions.

[emircan, 2016-04-26 19:47:08]

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
File content/renderer/media/canvas_capture_handler.cc (right):

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
content/renderer/media/canvas_capture_handler.cc:29: const
scoped_refptr<media::VideoFrame>& dest_frame) {
On 2016/04/26 00:07:14, mcasas wrote:
> nit: Since there's a few media::VideoFrame,
> consider adding a 
> using media::VideoFrame; 
> around l.25, which would make this easier
> to grok.

Done.

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
content/renderer/media/canvas_capture_handler.cc:45: pixel_index += 4)
On 2016/04/26 00:07:14, mcasas wrote:
> ultra-nit: s/pixel_index/pixel/ ?

Done.

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
File content/renderer/media/canvas_capture_handler_unittest.cc (right):

https://codereview.chromium.org/1918073003/diff/1/content/renderer/media/canv...
content/renderer/media/canvas_capture_handler_unittest.cc:88: const int offset =
odd_size ? kTestCanvasOddSizeOffset : 0;
On 2016/04/26 00:07:14, mcasas wrote:
> I'd say: Just use an integer parameter for the test (call it
> |extra_misalignment| or something like that here)
> as a test parameter and avoid the extra conversions.

Done.

[emircan, 2016-04-26 21:33:05]

The CQ bit was checked by emircan@chromium.org

[emircan, 2016-04-26 21:33:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/1918073003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-26 21:33:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918073003/20001

[commit-bot: I haz the power, 2016-04-26 21:38:05]

Description was changed from

==========
Fix odd size and visible rect issues in CanvasCaptureHandler

This CL addresses odd size frame problems found by fuzz tests.

BUG=606185
TEST=Minimized fuzz test case now passes. Also added unit tests.
==========

to

==========
Fix odd size and visible rect issues in CanvasCaptureHandler

This CL addresses odd size frame problems found by fuzz tests.

BUG=606185
TEST=Minimized fuzz test case now passes. Also added unit tests.
==========

[commit-bot: I haz the power, 2016-04-26 21:38:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 21:39:19]

Description was changed from

==========
Fix odd size and visible rect issues in CanvasCaptureHandler

This CL addresses odd size frame problems found by fuzz tests.

BUG=606185
TEST=Minimized fuzz test case now passes. Also added unit tests.
==========

to

==========
Fix odd size and visible rect issues in CanvasCaptureHandler

This CL addresses odd size frame problems found by fuzz tests.

BUG=606185
TEST=Minimized fuzz test case now passes. Also added unit tests.

Committed: https://crrev.com/e0dd9f840b3a21cd12bd3d83f5ca63302549dd21
Cr-Commit-Position: refs/heads/master@{#389899}
==========

[commit-bot: I haz the power, 2016-04-26 21:39:20]

Patchset 2 (id:??) landed as
https://crrev.com/e0dd9f840b3a21cd12bd3d83f5ca63302549dd21
Cr-Commit-Position: refs/heads/master@{#389899}