Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1925443002: Fix MediaRecorder bitrate configuration bug (Closed)

Created:
4 years, 8 months ago by mcasasG
Modified:
4 years, 8 months ago
Reviewers:
emircan, mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix MediaRecorder bitrate configuration bug The MediaRecorder API specifies that bitrates be communicated in bits per second, which is correctly plumbed through Chrome. However, VPx encoders expect its arguments to be specified in kilobits per second. This resulted in specifying any bitrate via the javascript API to be off by a thousand, resulting in enormous files. Change it so we convert bits -> kilobits by dividing by 1000 BUG=605750 R=mcasas@chromium.org Review URL: https://codereview.chromium.org/1913233002 Cr-Commit-Position: refs/heads/master@{#389411} (cherry picked from commit 0a58e7128c0559027991ae4671fb7b16274b7ba3) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_track_recorder.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925443002/1
4 years, 8 months ago (2016-04-26 21:12:00 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-26 21:12:02 UTC) #5
emircan
lgtm
4 years, 8 months ago (2016-04-26 21:25:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925443002/1
4 years, 8 months ago (2016-04-26 21:26:55 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:28:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698