MD Settings: Expanding cards should not overlap header

MD Settings: Expanding cards should not overlap header

Expanding cards overlap the header's drop shadow when they expand. Also,
if a page is scrolled past the start of a card and that card is then expanded,
the top of the card becomes visible over the header. This fixes both of those
by giving the header a (high) z-index, making it part of the stacking context.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/57b3eadebbb95a01dc932c14654032eab5b8013a
Cr-Commit-Position: refs/heads/master@{#392810}

[michaelpg, 2016-05-10 00:38:32]

Description was changed from

==========
MD Settings: Expanding cards should not overlap header

Expanding cards overlap the header's drop shadow when they expand. Also,
if a page is scrolled past the start of a card and that card is then expanded,
the top of the card becomes visible over the header. This fixes both of those
by giving the header a (high) z-index, making it part of the stacking context.

BUG=589681
R=dbeam@chromium.org
==========

to

==========
MD Settings: Expanding cards should not overlap header

Expanding cards overlap the header's drop shadow when they expand. Also,
if a page is scrolled past the start of a card and that card is then expanded,
the top of the card becomes visible over the header. This fixes both of those
by giving the header a (high) z-index, making it part of the stacking context.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-10 00:39:00]

More transitions polish.

[Dan Beam, 2016-05-10 00:46:37]

lgtm but use a smaller number if possible

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understandin...

https://codereview.chromium.org/1966543002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1966543002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:99: z-index: 100;
in a perfect world, we would not treat z-index as absolute, but as stacking
context-relative things so every level would not fight eachother

[michaelpg, 2016-05-10 02:29:13]

https://codereview.chromium.org/1966543002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1966543002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:99: z-index: 100;
On 2016/05/10 00:46:37, Dan Beam wrote:
> in a perfect world, we would not treat z-index as absolute, but as stacking
> context-relative things so every level would not fight eachother

My next version is slightly perfecter.

Giving the shadow a z-index > the container keeps the shadow on top; giving the
container a z-index makes it a stacking context that the expanding card stays
within.

[michaelpg, 2016-05-11 00:20:19]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-05-11 00:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1966543002/#ps40001
(title: "newline")

[commit-bot: I haz the power, 2016-05-11 00:20:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966543002/40001

[commit-bot: I haz the power, 2016-05-11 01:32:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-11 01:34:17]

Description was changed from

==========
MD Settings: Expanding cards should not overlap header

Expanding cards overlap the header's drop shadow when they expand. Also,
if a page is scrolled past the start of a card and that card is then expanded,
the top of the card becomes visible over the header. This fixes both of those
by giving the header a (high) z-index, making it part of the stacking context.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Expanding cards should not overlap header

Expanding cards overlap the header's drop shadow when they expand. Also,
if a page is scrolled past the start of a card and that card is then expanded,
the top of the card becomes visible over the header. This fixes both of those
by giving the header a (high) z-index, making it part of the stacking context.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/57b3eadebbb95a01dc932c14654032eab5b8013a
Cr-Commit-Position: refs/heads/master@{#392810}
==========

[commit-bot: I haz the power, 2016-05-11 01:34:18]

Patchset 3 (id:??) landed as
https://crrev.com/57b3eadebbb95a01dc932c14654032eab5b8013a
Cr-Commit-Position: refs/heads/master@{#392810}

[dschuyler, 2016-05-11 19:07:12]

On 2016/05/11 01:34:18, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/57b3eadebbb95a01dc932c14654032eab5b8013a
> Cr-Commit-Position: refs/heads/master@{#392810}

This appears to introduce an issue with settings dialogs. See
https://bugs.chromium.org/p/chromium/issues/detail?id=611146