Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: test/mac/gyptest-archs.py

Issue 196283023: ninja/mac: Fix multiarch link regression caused by 1871. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mac/archs/test-archs-multiarch.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mac/gyptest-archs.py
===================================================================
--- test/mac/gyptest-archs.py (revision 1873)
+++ test/mac/gyptest-archs.py (working copy)
@@ -39,8 +39,9 @@
# Build all targets except 'exe_32_64_no_sources' that does build
# but should not cause error when generating ninja files
targets = [
- 'static_32_64', 'shared_32_64', 'module_32_64', 'exe_32_64',
- 'exe_32_64_bundle', 'precompiled_prefix_header_mm_32_64',
+ 'static_32_64', 'shared_32_64', 'shared_32_64_bundle',
+ 'module_32_64', 'module_32_64_bundle',
+ 'exe_32_64', 'exe_32_64_bundle', 'precompiled_prefix_header_mm_32_64',
]
test.run_gyp('test-archs-multiarch.gyp', chdir='archs')
@@ -57,6 +58,17 @@
test.must_exist(result_file)
TestMac.CheckFileType(test, result_file, ['i386', 'x86_64'])
+ result_file = test.built_file_path('My Framework.framework/My Framework',
+ chdir='archs')
+ test.must_exist(result_file)
+ TestMac.CheckFileType(test, result_file, ['i386', 'x86_64'])
+ # Check that symbol "_x" made it into both versions of the binary:
+ if not all(['D _x' in subprocess.check_output(
+ ['nm', '-arch', arch, result_file]) for arch in ['i386', 'x86_64']]):
+ # This can only flakily fail, due to process ordering issues. If this
+ # does fail flakily, then something's broken, it's not the test at fault.
+ test.fail_test()
+
result_file = test.built_file_path(
'exe_32_64', chdir='archs', type=test.EXECUTABLE)
test.must_exist(result_file)
« no previous file with comments | « test/mac/archs/test-archs-multiarch.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698