Added a debug info UI for Blimp

blimp/client/feature/navigation_feature.cc

Index: blimp/client/feature/navigation_feature.cc
diff --git a/blimp/client/feature/navigation_feature.cc b/blimp/client/feature/navigation_feature.cc
index 34922363c31c9f7ba0b82d393e55fdf79b318457..b1103d5c97447d8f154bfb572495ba1d408b0c46 100644
--- a/blimp/client/feature/navigation_feature.cc
+++ b/blimp/client/feature/navigation_feature.cc
@@ -19,7 +19,8 @@
 namespace blimp {
 namespace client {
 
-NavigationFeature::NavigationFeature() {}
+NavigationFeature::NavigationFeature(BlimpConnectionDetails* details)
+    : connection_details_(details) {}

[Khushal, 2016/05/18 00:23:00]

DCHECK the |connection_details_| here.

[shaktisahu, 2016/05/19 21:39:18]

Done.

 
 NavigationFeature::~NavigationFeature() {}
 
@@ -64,6 +65,7 @@ void NavigationFeature::NavigateToUrlText(int tab_id,
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::LOAD_URL);
   navigation_message->mutable_load_url()->set_url(url.spec());
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
@@ -74,6 +76,7 @@ void NavigationFeature::Reload(int tab_id) {
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::RELOAD);
 
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
@@ -84,6 +87,7 @@ void NavigationFeature::GoForward(int tab_id) {
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::GO_FORWARD);
 
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
@@ -94,6 +98,7 @@ void NavigationFeature::GoBack(int tab_id) {
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::GO_BACK);
 
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
@@ -114,8 +119,10 @@ void NavigationFeature::ProcessMessage(
     case NavigationMessage::NAVIGATION_STATE_CHANGED: {
       const NavigationStateChangeMessage& details =
           navigation_message.navigation_state_changed();
-      if (details.has_url())
+      if (details.has_url()) {
         delegate->OnUrlChanged(tab_id, GURL(details.url()));

[Khushal, 2016/05/18 00:23:00]

The URL may change even if we are on the same page, and may not necessarily
indicate a new navigation. I think your aim here is to reset stats when a new
navigation is initiated?

You should be able to use details.page_load_completed() being false below to
know when a navigation starts. I have a change up to make this event more
accurate, https://codereview.chromium.org/1986883002/

+        connection_details_->ResetStats();
+      }
 
       if (details.has_title())
         delegate->OnTitleChanged(tab_id, details.title());