Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: blimp/client/feature/navigation_feature.h

Issue 1962393004: Added a debug info UI for Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Built debug UI Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/feature/navigation_feature.h
diff --git a/blimp/client/feature/navigation_feature.h b/blimp/client/feature/navigation_feature.h
index 751b872f486ebb3a8e316ea773bf1a86722c334a..a2ff09a16c00cb3835f859785b74342fccc8f04b 100644
--- a/blimp/client/feature/navigation_feature.h
+++ b/blimp/client/feature/navigation_feature.h
@@ -10,6 +10,7 @@
#include "base/containers/small_map.h"
#include "base/macros.h"
+#include "blimp/net/blimp_connection_details.h"
#include "blimp/net/blimp_message_processor.h"
class GURL;
@@ -35,7 +36,7 @@ class NavigationFeature : public BlimpMessageProcessor {
virtual void OnPageLoadStatusUpdate(int tab_id, bool completed) = 0;
};
- NavigationFeature();
+ NavigationFeature(BlimpConnectionDetails* details);
~NavigationFeature() override;
// Set the BlimpMessageProcessor that will be used to send
@@ -64,6 +65,8 @@ class NavigationFeature : public BlimpMessageProcessor {
DelegateMap delegates_;
+ BlimpConnectionDetails* connection_details_ = nullptr;
Khushal 2016/05/18 00:23:00 Do you need to initialize it to nullptr here? The
shaktisahu 2016/05/19 21:39:18 Done.
+
// Used to send BlimpMessage::NAVIGATION messages to the engine.
std::unique_ptr<BlimpMessageProcessor> outgoing_message_processor_;

Powered by Google App Engine
This is Rietveld 408576698