Added a debug info UI for Blimp

blimp/client/feature/navigation_feature.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/feature/navigation_feature.h"
 
 #include <map>
 #include <string>
 
 #include "blimp/common/create_blimp_message.h"
 #include "blimp/common/proto/blimp_message.pb.h"
 #include "blimp/common/proto/navigation.pb.h"
 #include "components/url_formatter/url_fixer.h"
 #include "net/base/net_errors.h"
 #include "url/gurl.h"
 #include "url/url_canon.h"
 #include "url/url_util.h"
 
 namespace blimp {
 namespace client {
 
-NavigationFeature::NavigationFeature() {}
+NavigationFeature::NavigationFeature(BlimpConnectionDetails* details)
+    : connection_details_(details) {}

[Khushal, 2016/05/18 00:23:00]

DCHECK the |connection_details_| here.

[shaktisahu, 2016/05/19 21:39:18]

Done.

 
 NavigationFeature::~NavigationFeature() {}
 
 void NavigationFeature::set_outgoing_message_processor(
     std::unique_ptr<BlimpMessageProcessor> processor) {
   outgoing_message_processor_ = std::move(processor);
 }
 
 void NavigationFeature::SetDelegate(int tab_id,
                                     NavigationFeatureDelegate* delegate) {
@@ skipping 24 matching lines @@
     std::string encoded_query(buffer.data(), buffer.length());
     url = GURL("https://www.google.com/#q=" + encoded_query);
     DCHECK(url.is_valid());
   }
 
   NavigationMessage* navigation_message;
   std::unique_ptr<BlimpMessage> blimp_message =
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::LOAD_URL);
   navigation_message->mutable_load_url()->set_url(url.spec());
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
 
 void NavigationFeature::Reload(int tab_id) {
   NavigationMessage* navigation_message;
   std::unique_ptr<BlimpMessage> blimp_message =
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::RELOAD);
 
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
 
 void NavigationFeature::GoForward(int tab_id) {
   NavigationMessage* navigation_message;
   std::unique_ptr<BlimpMessage> blimp_message =
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::GO_FORWARD);
 
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
 
 void NavigationFeature::GoBack(int tab_id) {
   NavigationMessage* navigation_message;
   std::unique_ptr<BlimpMessage> blimp_message =
       CreateBlimpMessage(&navigation_message, tab_id);
   navigation_message->set_type(NavigationMessage::GO_BACK);
 
+  connection_details_->ResetStats();
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
 
 void NavigationFeature::ProcessMessage(
     std::unique_ptr<BlimpMessage> message,
     const net::CompletionCallback& callback) {
   DCHECK(!callback.is_null());
   DCHECK(message->type() == BlimpMessage::NAVIGATION);
 
   int tab_id = message->target_tab_id();
   DCHECK(message->has_navigation());
   const NavigationMessage& navigation_message = message->navigation();
 
   NavigationFeatureDelegate* delegate = FindDelegate(tab_id);
   DCHECK(delegate) << "NavigationFeatureDelegate not found for tab " << tab_id;
   switch (navigation_message.type()) {
     case NavigationMessage::NAVIGATION_STATE_CHANGED: {
       const NavigationStateChangeMessage& details =
           navigation_message.navigation_state_changed();
-      if (details.has_url())
+      if (details.has_url()) {
         delegate->OnUrlChanged(tab_id, GURL(details.url()));

[Khushal, 2016/05/18 00:23:00]

The URL may change even if we are on the same page, and may not necessarily
indicate a new navigation. I think your aim here is to reset stats when a new
navigation is initiated?

You should be able to use details.page_load_completed() being false below to
know when a navigation starts. I have a change up to make this event more
accurate, https://codereview.chromium.org/1986883002/

+        connection_details_->ResetStats();
+      }
 
       if (details.has_title())
         delegate->OnTitleChanged(tab_id, details.title());
 
       if (details.has_loading())
         delegate->OnLoadingChanged(tab_id, details.loading());
 
       if (details.has_favicon()) {
         NOTIMPLEMENTED();
       }
@@ skipping 19 matching lines @@
 NavigationFeature::NavigationFeatureDelegate* NavigationFeature::FindDelegate(
     const int tab_id) {
   DelegateMap::const_iterator it = delegates_.find(tab_id);
   if (it != delegates_.end())
     return it->second;
   return nullptr;
 }
 
 }  // namespace client
 }  // namespace blimp