Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.cc

Issue 1962393003: log the click activate/deactive of translate icon on location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
diff --git a/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc b/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
index cde6058d21c03a729435f7e47034cf542d59f627..49e7b09e41545d824dae132a933d5326c509e175 100644
--- a/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
+++ b/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
@@ -7,6 +7,12 @@
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
+namespace translate {
+
+const char kTranslateBubbleUIEvent[] = "Translate.BubbleUiEvent";
+
+} // namespace translate
+
TranslateBubbleViewStateTransition::TranslateBubbleViewStateTransition(
TranslateBubbleModel::ViewState view_state)
: view_state_(view_state), view_state_before_advanced_view_(view_state) {
@@ -20,14 +26,14 @@ void TranslateBubbleViewStateTransition::SetViewState(
if (view_state != TranslateBubbleModel::VIEW_STATE_ADVANCED)
view_state_before_advanced_view_ = view_state;
else
- UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent",
+ UMA_HISTOGRAM_ENUMERATION(translate::kTranslateBubbleUIEvent,
translate::SET_STATE_OPTIONS,
translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
}
void TranslateBubbleViewStateTransition::GoBackFromAdvanced() {
DCHECK(view_state_ == TranslateBubbleModel::VIEW_STATE_ADVANCED);
- UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent",
+ UMA_HISTOGRAM_ENUMERATION(translate::kTranslateBubbleUIEvent,
translate::LEAVE_STATE_OPTIONS,
translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
SetViewState(view_state_before_advanced_view_);

Powered by Google App Engine
This is Rietveld 408576698