Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Side by Side Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.cc

Issue 1962393003: log the click activate/deactive of translate icon on location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h" 5 #include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 9
10 namespace translate {
11
12 const char kTranslateBubbleUIEvent[] = "Translate.BubbleUiEvent";
13
14 } // namespace translate
15
10 TranslateBubbleViewStateTransition::TranslateBubbleViewStateTransition( 16 TranslateBubbleViewStateTransition::TranslateBubbleViewStateTransition(
11 TranslateBubbleModel::ViewState view_state) 17 TranslateBubbleModel::ViewState view_state)
12 : view_state_(view_state), view_state_before_advanced_view_(view_state) { 18 : view_state_(view_state), view_state_before_advanced_view_(view_state) {
13 // The initial view type must not be 'Advanced'. 19 // The initial view type must not be 'Advanced'.
14 DCHECK_NE(TranslateBubbleModel::VIEW_STATE_ADVANCED, view_state_); 20 DCHECK_NE(TranslateBubbleModel::VIEW_STATE_ADVANCED, view_state_);
15 } 21 }
16 22
17 void TranslateBubbleViewStateTransition::SetViewState( 23 void TranslateBubbleViewStateTransition::SetViewState(
18 TranslateBubbleModel::ViewState view_state) { 24 TranslateBubbleModel::ViewState view_state) {
19 view_state_ = view_state; 25 view_state_ = view_state;
20 if (view_state != TranslateBubbleModel::VIEW_STATE_ADVANCED) 26 if (view_state != TranslateBubbleModel::VIEW_STATE_ADVANCED)
21 view_state_before_advanced_view_ = view_state; 27 view_state_before_advanced_view_ = view_state;
22 else 28 else
23 UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent", 29 UMA_HISTOGRAM_ENUMERATION(translate::kTranslateBubbleUIEvent,
24 translate::SET_STATE_OPTIONS, 30 translate::SET_STATE_OPTIONS,
25 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX); 31 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
26 } 32 }
27 33
28 void TranslateBubbleViewStateTransition::GoBackFromAdvanced() { 34 void TranslateBubbleViewStateTransition::GoBackFromAdvanced() {
29 DCHECK(view_state_ == TranslateBubbleModel::VIEW_STATE_ADVANCED); 35 DCHECK(view_state_ == TranslateBubbleModel::VIEW_STATE_ADVANCED);
30 UMA_HISTOGRAM_ENUMERATION("Translate.BubbleUiEvent", 36 UMA_HISTOGRAM_ENUMERATION(translate::kTranslateBubbleUIEvent,
31 translate::LEAVE_STATE_OPTIONS, 37 translate::LEAVE_STATE_OPTIONS,
32 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX); 38 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
33 SetViewState(view_state_before_advanced_view_); 39 SetViewState(view_state_before_advanced_view_);
34 } 40 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698