Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3418)

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 1962393003: log the click activate/deactive of translate icon on location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
index fb6f754d75f8686bd2c3bf1950c44944e33a06b9..53538cfce409a36270bd74ea3a6d764512011eb2 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h
@@ -54,10 +54,13 @@ class BubbleIconView : public views::InkDropHostView,
// Invoked prior to executing the command.
virtual void OnExecuting(ExecuteSource execute_source) = 0;
+ // Invoked after the icon is pressed.
+ virtual void OnPressed(bool activated) {}
+
// views::View:
void GetAccessibleState(ui::AXViewState* state) override;
- bool GetTooltipText(const gfx::Point& p, base::string16* tooltip) const
- override;
+ bool GetTooltipText(const gfx::Point& p,
+ base::string16* tooltip) const override;
gfx::Size GetPreferredSize() const override;
void Layout() override;
bool OnMousePressed(const ui::MouseEvent& event) override;
@@ -77,8 +80,7 @@ class BubbleIconView : public views::InkDropHostView,
// views::WidgetObserver:
void OnWidgetDestroying(views::Widget* widget) override;
- void OnWidgetVisibilityChanged(views::Widget* widget,
- bool visible) override;
+ void OnWidgetVisibilityChanged(views::Widget* widget, bool visible) override;
protected:
// Calls OnExecuting and runs |command_id_| with a valid |command_updater_|.

Powered by Google App Engine
This is Rietveld 408576698