build/toolchain/gcc_toolchain.gni: further fixes for var forwarding

build/toolchain/gcc_toolchain.gni: further fixes for var forwarding

BUG=551343
Committed: https://crrev.com/669d177408a77804273688ad465367d879b6b2af
Cr-Commit-Position: refs/heads/master@{#392040}

[Paweł Hajdan Jr., 2016-05-06 10:36:55]

phajdan.jr@chromium.org changed reviewers:
+ jochen@chromium.org

[Paweł Hajdan Jr., 2016-05-06 10:36:55]

To repro: tools/gn/bootstrap/bootstrap.py -v --gn-gen-args
'use_allocator="none"'

Also see https://codereview.chromium.org/1943583002 and
https://codereview.chromium.org/1950643003 .

DEBUG:root:Running: /tmp/tmpS1bsbG/gn gen
/usr/local/google/home/phajdan/chromium/src/out/Release
--args=use_allocator="none" is_debug=false
ERROR at //build/toolchain/gcc_toolchain.gni:415:32: Clobbering existing value.
                               "use_allocator",
                               ^--------------
The current scope already defines a value "use_allocator".
forward_variables_from() won't clobber existing values. If you want to
merge lists, you'll need to do this explicitly.
See the command-line "--args":1:15: value being clobbered.
use_allocator="none" is_debug=false
              ^-----
See //build/toolchain/gcc_toolchain.gni:466:3: whence it was called.
  gcc_toolchain(target_name) {
  ^---------------------------
See //build/toolchain/linux/BUILD.gn:8:1: whence it was called.
clang_toolchain("clang_arm") {
^-----------------------------
See //BUILD.gn:61:1: which caused the file to be included.
group("gn_all") {
^----------------
Command '['/tmp/tmpS1bsbG/gn', 'gen',
'/usr/local/google/home/phajdan/chromium/src/out/Release',
'--args=use_allocator="none" is_debug=false']' returned non-zero exit status 1

[Paweł Hajdan Jr., 2016-05-06 10:37:02]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 10:37:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961433003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961433003/1

[jochen (gone - plz use gerrit), 2016-05-06 10:37:46]

lgtm

[commit-bot: I haz the power, 2016-05-06 11:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 11:36:21]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-05-06 11:57:17]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-05-06 11:57:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961433003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961433003/1

[commit-bot: I haz the power, 2016-05-06 12:01:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-06 12:02:10]

Description was changed from

==========
build/toolchain/gcc_toolchain.gni: further fixes for var forwarding

BUG=551343
==========

to

==========
build/toolchain/gcc_toolchain.gni: further fixes for var forwarding

BUG=551343

Committed: https://crrev.com/669d177408a77804273688ad465367d879b6b2af
Cr-Commit-Position: refs/heads/master@{#392040}
==========

[commit-bot: I haz the power, 2016-05-06 12:02:11]

Patchset 1 (id:??) landed as
https://crrev.com/669d177408a77804273688ad465367d879b6b2af
Cr-Commit-Position: refs/heads/master@{#392040}