Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1950643003: Release clobber error fixes (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release clobber error fixes The change http://crrev.com/1943583002/ introduced a new check for clobbering on forward_variables_from. This patch fixes the associated errors for the Release build. BUG=None Committed: https://crrev.com/792a2d197553e0ec41a54c5b6a19064cdf080b41 Cr-Commit-Position: refs/heads/master@{#391786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/toolchain/gcc_toolchain.gni View 2 chunks +3 lines, -1 line 0 comments Download
M build/toolchain/nacl_toolchain.gni View 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 7 months ago (2016-05-04 15:50:51 UTC) #2
brettw
LGTM thanks
4 years, 7 months ago (2016-05-04 16:42:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950643003/1
4 years, 7 months ago (2016-05-05 11:05:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 11:08:23 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 11:10:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/792a2d197553e0ec41a54c5b6a19064cdf080b41
Cr-Commit-Position: refs/heads/master@{#391786}

Powered by Google App Engine
This is Rietveld 408576698