Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1960703002: [Part 3 of 6] Switch ColumnSpecifier to enum class. This makes straddling namespaces easier. (Closed)

Created:
4 years, 7 months ago by ncarter (slow)
Modified:
4 years, 7 months ago
Reviewers:
afakhry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tm_file_split2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch ColumnSpecifier to enum class. This makes straddling namespaces easier. [splitting apart task_manager_browsertest_util, part 3 of 6] BUG=606963 Committed: https://crrev.com/8e3d8ebf7f9f6f5f3782ffb4cbe4c77f64eccd7e Cr-Commit-Position: refs/heads/master@{#392651}

Patch Set 1 #

Patch Set 2 : Fixup. #

Patch Set 3 : Fix build #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 3 6 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 2 5 chunks +18 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
ncarter (slow)
Ahmed, please review (this is part 3)
4 years, 7 months ago (2016-05-06 21:45:19 UTC) #2
afakhry
lgtm. I like that splitting into several smaller CLs.
4 years, 7 months ago (2016-05-07 00:00:25 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1956753003 Patch 40001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-09 16:47:49 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 1956753003 Patch 60001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-09 21:36:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960703002/60001
4 years, 7 months ago (2016-05-10 16:51:08 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-10 18:19:14 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 18:21:21 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8e3d8ebf7f9f6f5f3782ffb4cbe4c77f64eccd7e
Cr-Commit-Position: refs/heads/master@{#392651}

Powered by Google App Engine
This is Rietveld 408576698