Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1956753003: [Part 2 of 6] Task manager browsertest utils are not actually used in any uitests. (Closed)

Created:
4 years, 7 months ago by ncarter (slow)
Modified:
4 years, 7 months ago
Reviewers:
afakhry, Lei Zhang
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@tm_file_split
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Task manager browsertest utils are not actually used in any uitests. [splitting apart task_manager_browsertest_util, part 2 of 6] BUG=606963 Committed: https://crrev.com/10fc4cc371d707f38d7774de1ea010a9b5b5a037 Cr-Commit-Position: refs/heads/master@{#392469}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
ncarter (slow)
Ahmed, please review (this is part 2 of several)
4 years, 7 months ago (2016-05-06 18:15:41 UTC) #3
afakhry
lgtm. Thanks for cleaning up!
4 years, 7 months ago (2016-05-06 23:55:47 UTC) #6
ncarter (slow)
+Lei for OWNERS stamp
4 years, 7 months ago (2016-05-09 16:46:47 UTC) #8
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-09 21:45:58 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 1956813002 Patch 100001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-09 21:50:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956753003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956753003/60001
4 years, 7 months ago (2016-05-09 22:39:43 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-09 23:20:33 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 23:22:29 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/10fc4cc371d707f38d7774de1ea010a9b5b5a037
Cr-Commit-Position: refs/heads/master@{#392469}

Powered by Google App Engine
This is Rietveld 408576698