Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/task_manager/task_manager_browsertest_util.h

Issue 1960703002: [Part 3 of 6] Switch ColumnSpecifier to enum class. This makes straddling namespaces easier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tm_file_split2
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_BROWSERTEST_UTIL_H_ 5 #ifndef CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_BROWSERTEST_UTIL_H_
6 #define CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_BROWSERTEST_UTIL_H_ 6 #define CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_BROWSERTEST_UTIL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
11 11
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 13
14 namespace content { 14 namespace content {
15 class WebContents; 15 class WebContents;
16 } 16 }
17 17
18 // TODO(nick): Move everything here (except for LegacyTaskManagerTesterImpl) 18 // TODO(nick): Move everything here (except for LegacyTaskManagerTesterImpl)
19 // into the task_management namespace. 19 // into the task_management namespace.
20 namespace task_manager { 20 namespace task_manager {
21 namespace browsertest_util { 21 namespace browsertest_util {
22 22
23 // Specifies some integer-valued column of numeric data reported by the task 23 // Specifies some integer-valued column of numeric data reported by the task
24 // manager model. Please add more here as needed by tests. 24 // manager model. Please add more here as needed by tests.
25 enum ColumnSpecifier { 25 enum class ColumnSpecifier {
26 V8_MEMORY, 26 V8_MEMORY,
27 V8_MEMORY_USED, 27 V8_MEMORY_USED,
28 SQLITE_MEMORY_USED, 28 SQLITE_MEMORY_USED,
29 29
30 COLUMN_NONE, // Default value. 30 COLUMN_NONE, // Default value.
31 }; 31 };
32 32
33 // An adapter that abstracts away the difference of old vs. new task manager. 33 // An adapter that abstracts away the difference of old vs. new task manager.
34 class TaskManagerTester { 34 class TaskManagerTester {
35 public: 35 public:
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 base::string16 MatchSubframe(const char* title); // "Subframe: " + title 102 base::string16 MatchSubframe(const char* title); // "Subframe: " + title
103 base::string16 MatchAnySubframe(); // "Subframe: *" 103 base::string16 MatchAnySubframe(); // "Subframe: *"
104 // "Utility: " + title 104 // "Utility: " + title
105 base::string16 MatchUtility(const base::string16& title); 105 base::string16 MatchUtility(const base::string16& title);
106 base::string16 MatchAnyUtility(); // "Utility: *" 106 base::string16 MatchAnyUtility(); // "Utility: *"
107 107
108 } // namespace browsertest_util 108 } // namespace browsertest_util
109 } // namespace task_manager 109 } // namespace task_manager
110 110
111 #endif // CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_BROWSERTEST_UTIL_H_ 111 #endif // CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_BROWSERTEST_UTIL_H_
OLDNEW
« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest.cc ('k') | chrome/browser/task_manager/task_manager_browsertest_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698