Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1960663002: Convert primitive receivers for API property callbacks (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convert primitive receivers for API property callbacks They're always in sloppy mode, so always do the conversion BUG=chromium:609134 R=bmeurer@chromium.org,verwaest@chromium.org LOG=n Committed: https://crrev.com/127d6781d91400397e15ba7302483643fb26c1da Cr-Commit-Position: refs/heads/master@{#36084}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M src/accessors.cc View 1 2 1 chunk +1 line, -0 lines 1 comment Download
M src/code-stubs.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-06 12:13:53 UTC) #1
Benedikt Meurer
LGTM.
4 years, 7 months ago (2016-05-06 12:15:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663002/20001
4 years, 7 months ago (2016-05-06 12:19:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/17465)
4 years, 7 months ago (2016-05-06 12:39:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663002/40001
4 years, 7 months ago (2016-05-06 13:40:15 UTC) #9
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1960663002/diff/40001/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/1960663002/diff/40001/src/accessors.cc#newcode264 src/accessors.cc:264: // We have a slight impedance mismatch between the ...
4 years, 7 months ago (2016-05-06 13:56:39 UTC) #10
Toon Verwaest
Not all sloppy functions convert receivers. Builtins are defined to not do it, for example. ...
4 years, 7 months ago (2016-05-06 14:09:40 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-06 14:10:18 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/127d6781d91400397e15ba7302483643fb26c1da Cr-Commit-Position: refs/heads/master@{#36084}
4 years, 7 months ago (2016-05-06 14:11:34 UTC) #14
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-06 14:16:51 UTC) #15
Message was sent while issue was closed.
On 2016/05/06 at 14:09:40, verwaest wrote:
> Not all sloppy functions convert receivers. Builtins are defined to not do it,
for example. Are you sure we want this?

Well, This is defined as Local<Object> so it better be a JSReceiver...

Powered by Google App Engine
This is Rietveld 408576698