Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: test/cctest/test-accessors.cc

Issue 1960663002: Convert primitive receivers for API property callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/accessors.cc ('K') | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 756 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 767
768 security_check_value = true; 768 security_check_value = true;
769 ExpectInt32("f()", 907); 769 ExpectInt32("f()", 907);
770 security_check_value = false; 770 security_check_value = false;
771 { 771 {
772 v8::TryCatch try_catch(isolate); 772 v8::TryCatch try_catch(isolate);
773 CompileRun("f();"); 773 CompileRun("f();");
774 CHECK(try_catch.HasCaught()); 774 CHECK(try_catch.HasCaught());
775 } 775 }
776 } 776 }
777
778 static void check_receiver(Local<String> name,
779 const v8::PropertyCallbackInfo<v8::Value>& info) {
780 CHECK(info.This()->IsObject());
781 }
782
783 TEST(Regress609134) {
784 v8::internal::FLAG_allow_natives_syntax = true;
785 LocalContext env;
786 v8::Isolate* isolate = env->GetIsolate();
787 v8::HandleScope scope(isolate);
788 auto fun_templ = v8::FunctionTemplate::New(isolate);
789 fun_templ->InstanceTemplate()->SetNativeDataProperty(v8_str("foo"),
790 check_receiver);
791
792 CHECK(env->Global()
793 ->Set(env.local(), v8_str("Fun"),
794 fun_templ->GetFunction(env.local()).ToLocalChecked())
795 .FromJust());
796
797 CompileRun(
798 "var f = new Fun();"
799 "Number.prototype.__proto__ = f;"
800 "[42][0].foo");
801 }
OLDNEW
« src/accessors.cc ('K') | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698