Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1960653002: Fix blacklisting password forms with Credential Manager API. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, jam, darin-cc_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix blacklisting password forms with Credential Manager API. The fix has two parts. Blacklisting the federated credential now works. The password bubble doesn't pop up for a federated credential when the site is blacklisted. BUG=607945 TBR=vabr@chromium.org Review-Url: https://codereview.chromium.org/1946563003 Cr-Commit-Position: refs/heads/master@{#391260} (cherry picked from commit 60883bfb1b4e342024a59b402924abdc23db596a) Committed: https://chromium.googlesource.com/chromium/src/+/84c2b499e62b79b728de94e0f3f3f109d619c6c4

Patch Set 1 #

Messages

Total messages: 3 (2 generated)
vasilii
4 years, 7 months ago (2016-05-06 10:24:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84c2b499e62b79b728de94e0f3f3f109d619c6c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698