Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher.cc

Issue 1960653002: Fix blacklisting password forms with Credential Manager API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/credential_manager_dispatcher.cc
diff --git a/components/password_manager/content/browser/credential_manager_dispatcher.cc b/components/password_manager/content/browser/credential_manager_dispatcher.cc
index 6f6780cfb2e3beafcf5e7d759101f66b9acef537..030612d58f80cdef09f2dcc87fbe32daa022ccf7 100644
--- a/components/password_manager/content/browser/credential_manager_dispatcher.cc
+++ b/components/password_manager/content/browser/credential_manager_dispatcher.cc
@@ -64,13 +64,14 @@ void CredentialManagerDispatcher::OnStore(
if (!client_->IsSavingAndFillingEnabledForCurrentPage())
return;
+ GURL origin = web_contents()->GetLastCommittedURL().GetOrigin();
std::unique_ptr<autofill::PasswordForm> form(
- CreatePasswordFormFromCredentialInfo(
- credential, web_contents()->GetLastCommittedURL().GetOrigin()));
+ CreatePasswordFormFromCredentialInfo(credential, origin));
form->skip_zero_click = !IsZeroClickAllowed();
form_manager_.reset(new CredentialManagerPasswordFormManager(
- client_, GetDriver(), *form, this));
+ client_, GetDriver(), *CreateObservedPasswordFormFromOrigin(origin),
+ std::move(form), this));
}
void CredentialManagerDispatcher::OnProvisionalSaveComplete() {
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698