Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1960063003: Settings People Revamp: Update PeopleHandler to use JS lifecycle calls. (Closed)

Created:
4 years, 7 months ago by tommycli
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People Revamp: Update PeopleHandler to use JS lifecycle calls. BUG=563721 Committed: https://crrev.com/3afa2a1267642e0fce68540a8179ec96073ec6e6 Cr-Commit-Position: refs/heads/master@{#392441}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add AllowJavascript to unit test to allow it to pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M chrome/browser/ui/webui/settings/people_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 1 8 chunks +36 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tommycli
dbeam: PTAL. One step closer to all Settings handlers being 'lifecycle correct'
4 years, 7 months ago (2016-05-09 19:39:27 UTC) #2
Dan Beam
sweet! lgtm
4 years, 7 months ago (2016-05-09 19:46:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960063003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960063003/20001
4 years, 7 months ago (2016-05-09 20:13:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/224499)
4 years, 7 months ago (2016-05-09 20:41:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960063003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960063003/40001
4 years, 7 months ago (2016-05-09 21:20:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-09 22:10:58 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 22:12:16 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3afa2a1267642e0fce68540a8179ec96073ec6e6
Cr-Commit-Position: refs/heads/master@{#392441}

Powered by Google App Engine
This is Rietveld 408576698